Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: unaligned 32-bit fields in .reloc section blocks of go.exe. #68260

Closed
ip7z opened this issue Jul 1, 2024 · 2 comments
Closed

cmd/link: unaligned 32-bit fields in .reloc section blocks of go.exe. #68260

ip7z opened this issue Jul 1, 2024 · 2 comments
Assignees
@thanm
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. OS-Windows

Comments

@ip7z
Copy link

ip7z commented Jul 1, 2024 •
edited
Loading

Go version

go1.22.4

Output of go env in your module/workspace:

*

What did you do?

look .reloc section in pe file: go.exe and another executable files compiled by go program.

What did you see happen?

.reloc section in compiled file (go.exe).
Each block represents the base relocations for a 4K page.
Some blocks in .reloc section in go.exe don't start on a 32-bit boundary.

It's related to source code is src\cmd\link\internal\ld\pe.go:

		blockSize := uint32(sizeOfPEbaseRelocBlock + len(b.entries)*2)
		out.Write32(p)
		out.Write32(blockSize)

Corrected code must add empty entry at the end of block, if len(b.entries) is odd.

What did you expect to see?

from PE Format description at microsoft site:
Each block represents the base relocations for a 4K page. Each block must start on a 32-bit boundary.
Probably it's old rule, because old processors required aligned 32-bit access for 32-bit fields.
@seankhliao seankhliao changed the title unaligned 32-bit fields in .reloc section blocks of go.exe. cmd/link: unaligned 32-bit fields in .reloc section blocks of go.exe. Jul 1, 2024
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 1, 2024
@thanm thanm self-assigned this Jul 1, 2024
@thanm thanm added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 1, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/595896 mentions this issue: cmd/link: align .reloc block starts by 32 bits for PE target

@cherrymui
Copy link
Member

cc @golang/windows

Mchnan pushed a commit to Mchnan/go-sylixos that referenced this issue Jul 9, 2024
@thanm
cmd/link: align .reloc block starts by 32 bits for PE target
94809cc 
Tweak the code that emits the PE ".reloc" section on Windows to ensure
that each relocation block is 32-bit aligned, which is required by the
PE standard.

Fixes golang#68260.

Change-Id: I39b75a7491b00fa97871aebb90d3be0ec09f9c40
Reviewed-on: https://go-review.googlesource.com/c/go/+/595896
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thanm thanm

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gopherbot @thanm @cherrymui @ip7z