Skip to content

x/telemetry/counter/countertest: add countertest.Close #68243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
findleyr opened this issue Jun 28, 2024 · 1 comment
Open

x/telemetry/counter/countertest: add countertest.Close #68243

findleyr opened this issue Jun 28, 2024 · 1 comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. telemetry x/telemetry issues
Milestone

Comments

@findleyr
Copy link
Member

The countertest package exists to test telemetry instrumentation, with a countertest.Open(dir) API to initialize the counter file in a temp directory.

But on Windows, we can't clean up that directory while the counter file is open. I think we should add a countertest.Close() function to close the counter file.

This is non-trivial: the file mapping logic is complicated, and likely assumes that the file stays open.

@gopherbot gopherbot added the telemetry x/telemetry issues label Jun 28, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jun 28, 2024
@findleyr
Copy link
Member Author

@hyangah recalls that munmap / Close may not be possible on some platforms. We should investigate.

@thanm thanm added the NeedsFix The path to resolution is known, but the work has not been done. label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. telemetry x/telemetry issues
Projects
None yet
Development

No branches or pull requests

3 participants