Skip to content

go/internal/gccgoimporter: go building failing with gcc 14.1.0 [1.22 backport] #67850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Jun 6, 2024 · 2 comments
Closed

go/internal/gccgoimporter: go building failing with gcc 14.1.0 [1.22 backport] #67850

gopherbot opened this issue Jun 6, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.22.5

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #67846 to be considered for backport to the next 1.22 minor release.

@gopherbot Please open backport issues.

This is due to some changes in gccgo that appeared in GCC 14. To fix this we will need to backport https://go.dev/cl/537195. That change is small and safe. This is already fixed at HEAD.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 6, 2024
@gopherbot gopherbot mentioned this issue Jun 6, 2024
Closed
@ianlancetaylor ianlancetaylor changed the title go building failing with gcc 14.1.0 [1.22 backport] go/internal/gccgoimporter: go building failing with gcc 14.1.0 [1.22 backport] Jun 6, 2024
@gopherbot gopherbot modified the milestones: Gccgo, Go1.22.5 Jun 6, 2024
@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Jun 12, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 12, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/592215 mentions this issue: [release-branch.go1.22] go/internal/gccgoimporter: recognize "any" as a builtin type

gopherbot pushed a commit that referenced this issue Jun 12, 2024
@ianlancetaylor @gopherbot
[release-branch.go1.22] go/internal/gccgoimporter: recognize "any" as…
b515c52 
… a builtin type

In CL 536715 we're changing the gofrontend export data to report
"any" as a builtin type. This permits us to distinguish the builtin
type from some other package-level type "any". That requires an update
to this code.

Fixes #67850

Change-Id: I91d75a056a155fa9892c4b25ab396cb4d39cc8e4
Reviewed-on: https://go-review.googlesource.com/c/go/+/537195
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: David Chase <drchase@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
(cherry picked from commit b8ac61e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/592215
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
@gopherbot
Copy link
Contributor Author

Closed by merging b515c52 to release-branch.go1.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.22.5
Development

No branches or pull requests
2 participants
@prattmic @gopherbot