Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: package-level variable initialization with constant dependencies doesn't match order specified in Go spec [1.22 backport] #67820

Closed
gopherbot opened this issue Jun 4, 2024 · 2 comments
Closed

cmd/compile: package-level variable initialization with constant dependencies doesn't match order specified in Go spec [1.22 backport] #67820

gopherbot opened this issue Jun 4, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.22.5

Comments

@gopherbot
Copy link
Contributor

@griesemer requested issue #66575 to be considered for backport to the next 1.22 minor release.

@gopherbot please consider this for backport to 1.22, it's a bug with respect to the spec.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jun 4, 2024
@gopherbot gopherbot mentioned this issue Jun 4, 2024
Closed
@gopherbot gopherbot added this to the Go1.22.4 milestone Jun 4, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/590395 mentions this issue: [release-branch.go1.22] cmd/compile: put constants before variables in initialization order

@gopherbot gopherbot modified the milestones: Go1.22.4, Go1.22.5 Jun 4, 2024
@dmitshur dmitshur added Documentation Issues describing a change to documentation. and removed Documentation Issues describing a change to documentation. labels Jun 4, 2024
@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Jun 12, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jun 12, 2024
@dmitshur dmitshur changed the title spec: package-level variable initialization with constant dependencies not explicitly specified in Go spec [1.22 backport] cmd/compile: package-level variable initialization with constant dependencies doesn't match order specified in Go spec [1.22 backport] Jun 12, 2024
@gopherbot
Copy link
Contributor Author

Closed by merging 5159a71 to release-branch.go1.22.

gopherbot pushed a commit that referenced this issue Jun 24, 2024
@randall77 @joedian
[release-branch.go1.22] cmd/compile: put constants before variables i…
5159a71 
…n initialization order

Fixes #67820.

Change-Id: I03f4d4577b88ad0a92b260b2efd0cb9fe5082b2f
Reviewed-on: https://go-review.googlesource.com/c/go/+/575075
Reviewed-by: Robert Griesemer <gri@google.com>
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/590395
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.22.5
Development

No branches or pull requests
3 participants
@prattmic @dmitshur @gopherbot