Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestLookupNoSuchHost failing on plan9/386 builder #67776

Closed
0intro opened this issue Jun 2, 2024 · 1 comment
Closed

net: TestLookupNoSuchHost failing on plan9/386 builder #67776

0intro opened this issue Jun 2, 2024 · 1 comment
Assignees
@0intro
Labels
NeedsFix The path to resolution is known, but the work has not been done. OS-Plan9
Milestone
Go1.23

Comments

@0intro
Copy link
Member

0intro commented Jun 2, 2024

Since the migration of the plan9/386 builder, the TestLookupNoSuchHost test is failing:

--- FAIL: TestLookupNoSuchHost (0.25s)
    --- FAIL: TestLookupNoSuchHost/LookupCNAME_NXDOMAIN (0.01s)
        --- FAIL: TestLookupNoSuchHost/LookupCNAME_NXDOMAIN/default_resolver (0.01s)
            lookup_test.go:1603: unexpected success
        --- FAIL: TestLookupNoSuchHost/LookupCNAME_NXDOMAIN/forced_go_resolver (0.00s)
            lookup_test.go:1603: unexpected success
        --- FAIL: TestLookupNoSuchHost/LookupCNAME_NXDOMAIN/forced_cgo_resolver (0.00s)
            lookup_test.go:1603: unexpected success
net.test 21894: warning: process exceeds 100 file descriptors
net.test 22606: warning: process exceeds 200 file descriptors
net.test 23370: warning: process exceeds 300 file descriptors
FAIL
FAIL	net	24.337s

The issue is that the queryDNS function in lookupCNAME return the resource does not exist; negrcode error string, which is not handled correctly.
@0intro 0intro added OS-Plan9 Builders x/build issues (builders, bots, dashboards) labels Jun 2, 2024
@0intro 0intro added this to the Go1.22.5 milestone Jun 2, 2024
@0intro 0intro self-assigned this Jun 2, 2024
@0intro 0intro modified the milestones: Go1.22.5, Go1.23 Jun 2, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/589715 mentions this issue: net: handle more error strings in lookupCNAME on Plan 9

@dmitshur dmitshur changed the title TestLookupNoSuchHost failing on plan9/386 builder net: TestLookupNoSuchHost failing on plan9/386 builder Jun 4, 2024
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed Builders x/build issues (builders, bots, dashboards) labels Jun 4, 2024
@0intro 0intro reopened this Jun 5, 2024
@golang golang deleted a comment from gopherbot Jun 7, 2024
@0intro 0intro closed this as completed Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0intro 0intro

Labels
NeedsFix The path to resolution is known, but the work has not been done. OS-Plan9
Projects
None yet
Milestone
Go1.23
Development

No branches or pull requests
3 participants
@dmitshur @0intro @gopherbot