Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: TestBrokenWorkspace_GOPACKAGESDRIVER is broken on legacy builders #67747

Closed
findleyr opened this issue May 31, 2024 · 3 comments
Closed

x/tools/gopls: TestBrokenWorkspace_GOPACKAGESDRIVER is broken on legacy builders #67747

findleyr opened this issue May 31, 2024 · 3 comments
Assignees
@adonovan
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.16.0

Comments

@findleyr
Copy link
Member

TestBrokenWorkspace_GOPACKAGESDRIVER is deterministically failing on legacy builders. It looks like this is caused by mismatching file paths due to symlinks.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 31, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 31, 2024
@findleyr findleyr added this to the gopls/v0.16.0 milestone May 31, 2024
@findleyr findleyr self-assigned this May 31, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/588765 mentions this issue: internal/test/integration/fake: resolve symlinks in sandbox directories

@findleyr findleyr assigned adonovan and unassigned findleyr May 31, 2024
@findleyr
Copy link
Member Author

Reassigning @adonovan as he was able to reproduce locally and root-cause.

@adonovan
Copy link
Member

Fixed by workaround in https://go.dev/cl/588767. See #67757 for a principled solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.16.0
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr