Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: typo in tutorial "getting started with multi-module workspaces" #67740

Closed
jeffreyhilaire opened this issue May 31, 2024 · 4 comments
Closed

x/website: typo in tutorial "getting started with multi-module workspaces" #67740

jeffreyhilaire opened this issue May 31, 2024 · 4 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. website
Milestone
Unreleased

Comments

@jeffreyhilaire
Copy link

What is the URL of the page with the issue?

https://go.dev/doc/tutorial/workspaces

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/125.0.0.0 Safari/537.36

Screenshot

image

What did you do?

This is a typo, not a behavioral bug so no action needed.

What did you expect to see?

I expected the sentence to read "The workspace now includes both the example.com/hello module and the golang.org/x/example/hello module, which provides the golang.org/x/example/hello/reverse package."

What did you see instead?

The sentence reads "The module now includes both the example.com/hello module and the golang.org/x/example/hello module, which provides the golang.org/x/example/hello/reverse package."
@gopherbot gopherbot added this to the Unreleased milestone May 31, 2024
@mknyszek mknyszek added the NeedsFix The path to resolution is known, but the work has not been done. label Jun 3, 2024
@mknyszek
Copy link
Contributor

mknyszek commented Jun 3, 2024

CC @matloob maybe?

@jeffreyhilaire if you're up for it, feel free to send a PR to https://github.com/golang/website.

@matloob
Copy link
Contributor

matloob commented Jun 3, 2024 •
edited by gabyhelp
Loading

@jeffreyhilaire I have a change that fixes it though I can retract it if you're interested in sending a PR.

https://go-review.googlesource.com/c/website/+/590043

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/590043 mentions this issue: _content/doc/tutorial: fix mixup between module and workspace

@jeffreyhilaire
Copy link
Author

@matloob thank you for the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. website
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@mknyszek @gopherbot @jeffreyhilaire @matloob