-
Notifications
You must be signed in to change notification settings - Fork 18k
crypto/x509: wrong value of RevocationList.AuthorityKeyId #67571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Comments
cc @FiloSottile @rolandshoemaker @golang/security |
Duplicate of #57461 |
Change https://go.dev/cl/587455 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
May 22, 2024
This looks like a oversight in CL 416354. Fixes #67571 Fixes #57461 Change-Id: I564c008989fecf84b437e123d27121ac907642fa GitHub-Last-Rev: fec88bb GitHub-Pull-Request: #67576 Reviewed-on: https://go-review.googlesource.com/c/go/+/587455 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Roland Shoemaker <roland@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Go version
go version go1.20.6 windows/amd64
Output of
go env
in your module/workspace:What did you do?
What did you see happen?
AuthorityKeyId is not decoded from DER completely, it contains DER prefix
SEQUENCE [0]
For a sample CRL:
3016 8014 99c826668f2d01b54a27ae658284092f2dab97fc
instead of99c826668f2d01b54a27ae658284092f2dab97fc
RevocationList.AuthorityKeyId is not decoded here: parser.go
What did you expect to see?
Correctly decoded AuthorityKeyId value.
RevocationList.AuthorityKeyId should be decoded same way as Certificate.AuthorityKeyId: parser.go
The text was updated successfully, but these errors were encountered: