x/tools/gopls: new CodeAction: "Show arm64 assembly for function f..." #67478
Labels
FeatureRequest
Issues asking for a new feature that does not need a proposal.
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
adonovan
added
the
FeatureRequest
gopherbot
added
Tools
|
Change https://go.dev/cl/588395 mentions this issue: |
worstell
pushed a commit
to block/ftl-golang-tools
that referenced
this issue
Jun 17, 2024
This CL adds a new code action to display the Go assembly code produced for the enclosing function, and all its nested functions. Each instruction is marked up with a link that causes cursor navigation in the editor, using the magic of LSP's showDocument. Each page load causes a recompile. (A cold build may take a few seconds in a large project.) The architecture is determined by the view: for most files it will be the default GOARCH, but for arch-tagged files it will be the appropriate one. + Test + Release note Fixes golang/go#67478 Change-Id: I51285215e9b27c510076c64eeb7b7ae3899f8a59 Reviewed-on: https://go-review.googlesource.com/c/tools/+/588395 Reviewed-by: Robert Findley <rfindley@google.com> Auto-Submit: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
worstell
pushed a commit
to block/ftl-golang-tools
that referenced
this issue
Nov 14, 2024
This CL adds a new code action to display the Go assembly code produced for the enclosing function, and all its nested functions. Each instruction is marked up with a link that causes cursor navigation in the editor, using the magic of LSP's showDocument. Each page load causes a recompile. (A cold build may take a few seconds in a large project.) The architecture is determined by the view: for most files it will be the default GOARCH, but for arch-tagged files it will be the appropriate one. + Test + Release note Fixes golang/go#67478 Change-Id: I51285215e9b27c510076c64eeb7b7ae3899f8a59 Reviewed-on: https://go-review.googlesource.com/c/tools/+/588395 Reviewed-by: Robert Findley <rfindley@google.com> Auto-Submit: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When optimizing code, or trying to track down some crash bugs, it can be helpful to inspect the assembly code that the compiler generates for a particular function. Gopls should add a "Source action..." (CodeAction) named "Show $GOARCH assembly for function f...", where $GOARCH is the current view's GOARCH, and f is the name of the function enclosing the selection. This would cause the LSP client to visit a web page containing the output of
go build -gcflags=-Sfor that package, with the page scrolled to put the current function in view.Bonus marks if each /blah/blah/foo.go:123 reference is replaced by a discreet link that navigates the client editor to that source location.
Even more bonus marks if assembly is post-processed so that block labels and control jumps are all connected up, in the style of @aclements' https://github.com/aclements/objbrowse.
The text was updated successfully, but these errors were encountered: