Skip to content

x/tools/gopls/internal/test/integration/codelens: spurious TestGCDetails_Toggle failure #67428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adonovan opened this issue May 16, 2024 · 4 comments
Closed

x/tools/gopls/internal/test/integration/codelens: spurious TestGCDetails_Toggle failure #67428

adonovan opened this issue May 16, 2024 · 4 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.16.0

Comments

@adonovan
Copy link
Member

adonovan commented May 16, 2024 •
edited
Loading 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test ~ `^TestGCDetails_Toggle/.*`

Observed in one builder in the context of https://go.dev/cl/585277; test passed after re-try.

--- FAIL: TestGCDetails_Toggle/default (2.01s)
    gcdetails_test.go:52: waiting on:
        Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)" is met, must have:
        any diagnostics for file "main.go", with message containing "42 escapes", with diagnostic "optimizer details" with severity Information and tag []
        
        err:condition has final verdict Unmeetable
        
        state:
        #### log messages (see RPC logs for full text):
        	Info: "2024/05/16 03:04:39 Created View (#11)\n\tdirector...
        	Info: "2024/05/16 03:04:40 go/packages.Load #27\n\tview_i...
        
        #### diagnostics:
        	main.go (version 1):
        
        #### outstanding work:
        	diagnosing unknown file modification: 0.00
        #### completed work:
        	Checking telemetry prompt: 1
        	diagnosing opened files: 1
        	Toggling GC Details: 1
        	diagnosing initial workspace load: 1
        	Setting up workspace: 1
...
@adonovan adonovan self-assigned this May 16, 2024
@adonovan adonovan added this to the gopls/v0.16.0 milestone May 16, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 16, 2024
@findleyr
Copy link
Member

Attempted to add a watchflakes stanza...

@findleyr findleyr mentioned this issue May 20, 2024
Closed
@findleyr findleyr assigned findleyr and unassigned adonovan May 21, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/586878 mentions this issue: gopls/internal/test/integration: fix race in TestGCDetails_Toggle

@gopherbot
Copy link
Contributor

Sorry, but there were parse errors in the watch flakes script.
The script I found was:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test ~ "^TestGCDetails_Toggle/.*"

And the problems were:

script:2.91: ~ requires backquoted regexp

See https://go.dev/wiki/Watchflakes for details.

— watchflakes

@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test ~ `^TestGCDetails_Toggle/.*`
2024-05-17 17:09 x_tools-go1.22-darwin-amd64_13 tools@de1032b1 release-branch.go1.22@185457da x/tools/gopls/internal/test/integration/codelens.TestGCDetails_Toggle/default (log) 
=== RUN   TestGCDetails_Toggle/default
    gcdetails_test.go:52: waiting on:
        Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)" is met, must have:
        any diagnostics for file "main.go", with message containing "42 escapes", with diagnostic "optimizer details" with severity Information and tag []
        
        err:condition has final verdict Unmeetable
        
        state:
        #### log messages (see RPC logs for full text):
        	Info: "2024/05/17 10:16:09 Created View (#11)\n\tdirector...
...
[Trace - 10:16:09.894 AM] Received response 'workspace/executeCommand - (3)' in 1ms.
Result: null


[Trace - 10:16:10.486 AM] Received notification '$/progress'.
Params: {"token":"1972677595541516849","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestGCDetails_Toggle/default"
--- FAIL: TestGCDetails_Toggle/default (1.40s)

— watchflakes

@hyangah hyangah mentioned this issue May 23, 2024
Closed
@gabyhelp gabyhelp mentioned this issue Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
gopls/v0.16.0
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr