Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/cipher: Speed up CTR cipher #6741

Closed
hanwen opened this issue Nov 8, 2013 · 5 comments
Closed

crypto/cipher: Speed up CTR cipher #6741

hanwen opened this issue Nov 8, 2013 · 5 comments
Labels
FrozenDueToAge

Comments

@hanwen
Copy link
Contributor

hanwen commented Nov 8, 2013 

I added a benchmark to gosshnew/ssh. Its profile suggests that 40% of time is spent in
ctr.XORKeyStream from crypto/cipher.  

XORKeyStream is xor'ing a byte at a time. If we can do words at a time, it could
probably go much faster.

Linux x86_64 , tip (18437:e6794866ebeb)
@hanwen
Copy link
Contributor Author

hanwen commented Nov 11, 2013

Comment 1:

I cooked up https://golang.org/cl/24250044/ - speeds CTR and OFB by a factor
2.5x, CBC by 1.5x and GCM by 10%

@rsc
Copy link
Contributor

rsc commented Nov 27, 2013

Comment 2:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 3:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 4:

Labels changed: added repo-main.

@agl
Copy link
Contributor

agl commented Dec 11, 2013

Comment 5:

This issue was closed by revision 5744be9.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@agl @hanwen @rsc @gopherbot