Skip to content

x/sys/unix: TestIoctlGetEthtoolDrvinfo failures #67350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue May 14, 2024 · 4 comments
Closed

x/sys/unix: TestIoctlGetEthtoolDrvinfo failures #67350

gopherbot opened this issue May 14, 2024 · 4 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/sys/unix" && test == "TestIoctlGetEthtoolDrvinfo"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestIoctlGetEthtoolDrvinfo
    syscall_linux_test.go:61: end0: "st_gmac"
    syscall_linux_test.go:57: failed to get ethtool driver info for "end1": device or resource busy
--- FAIL: TestIoctlGetEthtoolDrvinfo (0.00s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 14, 2024
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 14, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 14, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/sys/unix" && test == "TestIoctlGetEthtoolDrvinfo"
2024-05-09 17:46 x_sys-gotip-linux-riscv64 sys@f34bb9fc go@f43d9c40 x/sys/unix.TestIoctlGetEthtoolDrvinfo (log) 
=== RUN   TestIoctlGetEthtoolDrvinfo
    syscall_linux_test.go:61: end0: "st_gmac"
    syscall_linux_test.go:57: failed to get ethtool driver info for "end1": device or resource busy
--- FAIL: TestIoctlGetEthtoolDrvinfo (0.00s)

— watchflakes

@mengzhuo
Copy link
Contributor

mengzhuo commented May 17, 2024 •
edited
Loading

It looks like a kernel bug to me.
dmesg shows DMA init failed.

[   46.926773] starfive-eth-plat 16040000.ethernet end1: PHY [stmmac-1:00] driver [YT8531 Gigabit Ethernet] (irq=POLL
)
[   46.939479] starfive-eth-plat 16040000.ethernet end1: Register MEM_TYPE_PAGE_POOL RxQ-0
[   47.954682] starfive-eth-plat 16040000.ethernet: Failed to reset the dma
[   47.961409] starfive-eth-plat 16040000.ethernet end1: stmmac_hw_setup: DMA engine initialization failed
[   47.970849] starfive-eth-plat 16040000.ethernet end1: stmmac_open: Hw setup failed

Using ethtool end1 has same outcome.

root@visionfive2-2:~# ethtool end1
netlink error: Device or resource busy
netlink error: Device or resource busy

@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/586435 mentions this issue: unix: skip ethtool driver test for busy interface

@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. FixPending Issues that have a fix which has not yet been reviewed or submitted. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 17, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/sys/unix" && test == "TestIoctlGetEthtoolDrvinfo"
2024-05-13 22:24 x_sys-go1.21-linux-riscv64 sys@6943ab67 release-branch.go1.21@6f521957 x/sys/unix.TestIoctlGetEthtoolDrvinfo (log) 
=== RUN   TestIoctlGetEthtoolDrvinfo
    syscall_linux_test.go:61: end0: "st_gmac"
    syscall_linux_test.go:57: failed to get ethtool driver info for "end1": device or resource busy
--- FAIL: TestIoctlGetEthtoolDrvinfo (0.00s)

— watchflakes

@mdlayher mdlayher mentioned this issue Jun 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Go Compiler / Runtime
Status: Done
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@mengzhuo @dmitshur @gopherbot