-
Notifications
You must be signed in to change notification settings - Fork 17.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/gopls: Session.SnapshotOf gets stuck #67289
Comments
Can you try installing gopls@v0.14.2 to see if it fixes your problem?
That will help us narrow down the regression. |
@findleyr It seems the problem has been fixed. thanks
|
I am experiencing the same issue, including after downgrading to gopls@0.14.2: Run
Run
Run code -v or code-insiders -v to get version of VS Code or VS Code Insiders.
|
@williambao could you use gopls@v0.15.2 with the following settings, and report whether you still have the reported problem saving files? That would help us narrow down the problem. settings.json
For both @williambao and @akgerber: does |
|
@akgerber would you be able to capture RPC logs from a brief VS Code session that reproduces the problem? |
I will attempt to capture RPC logs in a test repo. |
@akgerber can you try recompiling gopls with go 1.22.2?
|
I'll give that a shot, thanks! |
Hmm, the issue seems to persist after recompiling |
@akgerber hmm, that's interesting. If you can capture RPC logs, it would be very helpful. |
Timed out in state WaitingForInfo. Closing. (I am just a bot, though. Please speak up if this is a mistake or you have the requested information.) |
Sorry, this is definitely not waiting for info. Apologies that this languished for so long: the team has been very busy with the freeze, and apparently this has tab has been open in my browser for time WaitingForInfo timeout period.... |
Looks like the server was fine until around request 92 and then got stuck:
Between 91 and 92 we see these events, indicating that gopls scanned go/pkg/mod, apparently successfully:
But after this point, not only codeAction requests, but all requests including semanticTokens (e.g. 95), foldingRange (97), documentSymbol (98), and codeLens (99), all start hanging; no further responses are observed. My guess is Session.SnapshotOf is stuck, but how I do not know. |
Thanks @adonovan for investigating. |
Recently, vscode has become unable to save files normally. Every time I try to save the file, there are will popup a dialog shown in the video below , and will not disappeared.
Saving 'xxx.go': Getting code actions from "Go"
CleanShot.2024-04-02.at.12.30.41.mp4
I have tried restarting and reinstalling vscode. but failed to fix the problem.
What version of Go, VS Code & VS Code Go extension are you using?
Version Information
go version
to get version of Go from the VS Code integrated terminal.gopls -v version
to get version of Gopls from the VS Code integrated terminal.code -v
orcode-insiders -v
to get version of VS Code or VS Code Insiders.Go: Locate Configured Go Tools
command.Tools Configuration
Environment
GOBIN: undefined
toolsGopath:
gopath: /Users/william/go
GOROOT: /usr/local/go
PATH: /Users/william/miniconda3/bin:/Users/william/miniconda3/condabin:/Users/william/.nvm/versions/node/v21.5.0/bin:/Library/Frameworks/Python.framework/Versions/3.11/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Library/Apple/usr/bin:/usr/local/share/dotnet:~/.dotnet/tools:/usr/local/go/bin:/Users/william/.cargo/bin:/Users/william/.orbstack/bin:/Users/william/go/bin:/bin:/Users/william/Library/Android/sdk/platform-tools:/Users/william/.dotnet/tools
Tools
Go env
Workspace Folder (canzhi-im): /Users/william/dev/github/williambao/canzhi-im
The text was updated successfully, but these errors were encountered: