Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: should only abort on unknown GOARCH when trying to use gc toolchain #6728

Closed
mwhudson opened this issue Nov 6, 2013 · 6 comments
Closed

cmd/go: should only abort on unknown GOARCH when trying to use gc toolchain #6728

mwhudson opened this issue Nov 6, 2013 · 6 comments
Labels
FrozenDueToAge
Milestone
Go1.3

Comments

@mwhudson
Copy link
Contributor

mwhudson commented Nov 6, 2013 

The go tool's build.go has an init function that aborts if it cannot map GOARCH to a
archChar:

https://code.google.com/p/go/source/browse/src/cmd/go/build.go?r=ebb2ba0fe943fca77eed3d4d1d83bad57039d61f

But the archChar is only used by the gc toolchain -- if -compiler gccgo is in effect we
should be able to just carry on regardless.  The check should be made lazy, in other
words.
@rsc
Copy link
Contributor

rsc commented Nov 27, 2013

Comment 1:

Labels changed: added go1.3maybe.

@dsymonds
Copy link
Contributor

dsymonds commented Dec 2, 2013

Comment 2:

Labels changed: added priority-later, toolbug, gccgo, removed priority-triage.

@mwhudson
Copy link
Contributor Author

mwhudson commented Dec 2, 2013

Comment 3:

FWIW, mwhudson/faux@23a8630
is an attempt to fix this.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 4:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 5:

Labels changed: added repo-main.

@davecheney
Copy link
Contributor

Comment 6:

Fixed by revision 5dd2679d2a0d

Labels changed: added release-go1.3, removed priority-later, release-none.

Status changed to Fixed.

@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.3
Development

No branches or pull requests
5 participants
@davecheney @dsymonds @rsc @mwhudson @gopherbot