Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/asn1: Incorrect parsing of non-printable strings in sequences #6726

Closed
calmh opened this issue Nov 6, 2013 · 6 comments
Closed

encoding/asn1: Incorrect parsing of non-printable strings in sequences #6726

calmh opened this issue Nov 6, 2013 · 6 comments
Labels
FrozenDueToAge
Milestone
Go1.3

Comments

@calmh
Copy link
Contributor

calmh commented Nov 6, 2013 

The asn1 decoder goes to some pain to correctly parse the various kinds of strings into
regular Go strings when unmarshalling. Some of the pain was forgotten when dealing with
strings in sequences.

I.e. the "foo\\bar" will survive marshalling/unmarshalling but the slice
[]string{"foo", "foo\\bar"} will not -- it causes a "sequence
tag mismatch" error.
@calmh
Copy link
Contributor Author

calmh commented Nov 6, 2013

Comment 1:

https://golang.org/cl/22460043/

@rsc
Copy link
Contributor

rsc commented Nov 7, 2013

Comment 2:

Labels changed: added priority-later, go1.3, removed priority-triage.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 3:

Labels changed: added release-go1.3.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 4:

Labels changed: removed go1.3.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 5:

Labels changed: added repo-main.

@agl
Copy link
Contributor

agl commented Dec 18, 2013

Comment 6:

This issue was closed by revision 2b693b7.

Status changed to Fixed.

@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.3
Development

No branches or pull requests
4 participants
@agl @rsc @calmh @gopherbot