Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/analysis/simplifyrange: adapt for go1.23 range over func #67239

Open
adonovan opened this issue May 7, 2024 · 0 comments
Open

x/tools/gopls/internal/analysis/simplifyrange: adapt for go1.23 range over func #67239

adonovan opened this issue May 7, 2024 · 0 comments
Labels
gopls/analysis Issues related to running analysis in gopls gopls Issues related to the Go language server, gopls. Refactoring Issues related to refactoring tools Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.16.0

Comments

@adonovan
Copy link
Member

adonovan commented May 7, 2024

When it sees for _ = range x { ... }, the simplifyrange analyzer in gopls offers a suggested fix to remove the _ = part. This is not legal in go1.23 if x is a func.
@adonovan adonovan added this to the gopls/v0.16.0 milestone May 7, 2024
@adonovan adonovan added the gopls/analysis Issues related to running analysis in gopls label May 7, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 7, 2024
@adonovan adonovan added the Refactoring Issues related to refactoring tools label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls/analysis Issues related to running analysis in gopls gopls Issues related to the Go language server, gopls. Refactoring Issues related to refactoring tools Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.16.0
Development

No branches or pull requests
2 participants
@adonovan @gopherbot