Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: SIGBUS unaligned access on mips64 via qemu-mips64 [1.21 backport] #67164

Closed
gopherbot opened this issue May 3, 2024 · 6 comments
Closed

cmd/compile: SIGBUS unaligned access on mips64 via qemu-mips64 [1.21 backport] #67164

gopherbot opened this issue May 3, 2024 · 6 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.21.11

Comments

@gopherbot
Copy link

@randall77 requested issue #67160 to be considered for backport to the next 1.21 minor release.

@gopherbot please open backport issues.

This looks like it started in 1.20. So maybe that CL isn't to blame? I think it would have landed in 1.21 if I'm getting my math right.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 3, 2024
@gopherbot gopherbot mentioned this issue May 3, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 3, 2024
@gopherbot gopherbot added this to the Go1.21.10 milestone May 3, 2024
@randall77
Copy link
Contributor

This is a bug that miscompiles some type equality functions on architectures that can't do unaligned loads. There is no easy workaround.

@gopherbot
Copy link
Author

Change https://go.dev/cl/583303 mentions this issue: [release-branch.go1.21] cmd/compile: don't combine loads in generated equality functions

gopherbot pushed a commit that referenced this issue May 6, 2024
@randall77
[release-branch.go1.21] cmd/compile: don't combine loads in generated…
58e77ad 
… equality functions

... if the architecture can't do unaligned loads.
We already handle this in a few places, but this particular place
was added in CL 399542 and missed this additional restriction.

Fixes #67164

Change-Id: I45988f11ff3ed45df1c4da3f0931ab1fdb22dbfe
Reviewed-on: https://go-review.googlesource.com/c/go/+/583175
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Auto-Submit: Keith Randall <khr@google.com>
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Derek Parker <parkerderek86@gmail.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
(cherry picked from commit 3c72dd5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/583303
@gopherbot
Copy link
Author

Closed by merging 58e77ad to release-branch.go1.21.

@cherrymui
Copy link
Member

cherrymui commented May 6, 2024 •
edited

CL submitted reverted. Reopen for cherry-pick review (the dashboard only shows open issues).

@cherrymui cherrymui reopened this May 6, 2024
@cherrymui cherrymui reopened this May 6, 2024
@gopherbot gopherbot modified the milestones: Go1.21.10, Go1.21.11 May 7, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/583799 mentions this issue: [release-branch.go1.21] cmd/compile: don't combine loads in generated equality functions

@cherrymui cherrymui added the CherryPickApproved Used during the release process for point releases label May 8, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label May 8, 2024
gopherbot pushed a commit that referenced this issue May 10, 2024
@randall77 @cherrymui
[release-branch.go1.21] cmd/compile: don't combine loads in generated…
8fbd4d7 
… equality functions

... if the architecture can't do unaligned loads.
We already handle this in a few places, but this particular place
was added in CL 399542 and missed this additional restriction.

Fixes #67164

(Reroll of CL 583303)

Change-Id: Id067cc2e39d7d199672f2017f7f53991fb23f8d4
Reviewed-on: https://go-review.googlesource.com/c/go/+/583799
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
@cherrymui
Copy link
Member

CL submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.21.11
Development

No branches or pull requests
3 participants
@randall77 @gopherbot @cherrymui