Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestLookupNoSuchHost failing on Plan 9 #67096

Closed
0intro opened this issue Apr 28, 2024 · 1 comment
Closed

net: TestLookupNoSuchHost failing on Plan 9 #67096

0intro opened this issue Apr 28, 2024 · 1 comment
Labels
OS-Plan9
Milestone
Go1.23

Comments

@0intro
Copy link
Member

0intro commented Apr 28, 2024

Since CL 532217, TestLookupNoSuchHost is failing on Plan 9.

--- FAIL: TestLookupNoSuchHost (216.41s)
    --- FAIL: TestLookupNoSuchHost/LookupHost_NXDOMAIN (108.13s)
        --- FAIL: TestLookupNoSuchHost/LookupHost_NXDOMAIN/default_resolver (36.05s)
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 1s after failure lookup invalid.invalid.: write /net/cs: cs: can't translate address: dns: name does not exist
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 5s after failure lookup invalid.invalid.: write /net/cs: cs: can't translate address: dns: name does not exist
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 30s after failure lookup invalid.invalid.: write /net/cs: cs: can't translate address: dns: name does not exist
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1628: unexpected error: lookup invalid.invalid.: write /net/cs: cs: can't translate address: dns: name does not exist
        --- FAIL: TestLookupNoSuchHost/LookupHost_NXDOMAIN/forced_go_resolver (36.04s)
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 1s after failure lookup invalid.invalid.: write /net/cs: cs: can't translate address: dns: name does not exist
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 5s after failure lookup invalid.invalid.: write /net/cs: cs: can't translate address: dns: name does not exist
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 30s after failure lookup invalid.invalid.: write /net/cs: cs: can't translate address: dns: name does not exist
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1628: unexpected error: lookup invalid.invalid.: write /net/cs: cs: can't translate address: dns: name does not exist
        --- FAIL: TestLookupNoSuchHost/LookupHost_NXDOMAIN/forced_cgo_resolver (36.04s)
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 1s after failure lookup invalid.invalid.: write /net/cs: cs: can't translate address: dns: name does not exist
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 5s after failure lookup invalid.invalid.: write /net/cs: cs: can't translate address: dns: name does not exist
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 30s after failure lookup invalid.invalid.: write /net/cs: cs: can't translate address: dns: name does not exist
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1628: unexpected error: lookup invalid.invalid.: write /net/cs: cs: can't translate address: dns: name does not exist
    --- FAIL: TestLookupNoSuchHost/LookupHost_NODATA (108.18s)
        --- FAIL: TestLookupNoSuchHost/LookupHost_NODATA/default_resolver (36.07s)
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 1s after failure lookup _ldap._tcp.google.com.: write /net/cs: cs: can't translate address: dns: resource does not exist; negrcode
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 5s after failure lookup _ldap._tcp.google.com.: write /net/cs: cs: can't translate address: dns: resource does not exist; negrcode
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 30s after failure lookup _ldap._tcp.google.com.: write /net/cs: cs: can't translate address: dns: resource does not exist; negrcode
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1628: unexpected error: lookup _ldap._tcp.google.com.: write /net/cs: cs: can't translate address: dns: resource does not exist; negrcode
        --- FAIL: TestLookupNoSuchHost/LookupHost_NODATA/forced_go_resolver (36.07s)
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 1s after failure lookup _ldap._tcp.google.com.: write /net/cs: cs: can't translate address: dns: resource does not exist; negrcode
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 5s after failure lookup _ldap._tcp.google.com.: write /net/cs: cs: can't translate address: dns: resource does not exist; negrcode
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 30s after failure lookup _ldap._tcp.google.com.: write /net/cs: cs: can't translate address: dns: resource does not exist; negrcode
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1628: unexpected error: lookup _ldap._tcp.google.com.: write /net/cs: cs: can't translate address: dns: resource does not exist; negrcode
        --- FAIL: TestLookupNoSuchHost/LookupHost_NODATA/forced_cgo_resolver (36.03s)
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 1s after failure lookup _ldap._tcp.google.com.: write /net/cs: cs: can't translate address: dns: resource does not exist; negrcode
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 5s after failure lookup _ldap._tcp.google.com.: write /net/cs: cs: can't translate address: dns: resource does not exist; negrcode
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1623: backoff 30s after failure lookup _ldap._tcp.google.com.: write /net/cs: cs: can't translate address: dns: resource does not exist; negrcode
            lookup_test.go:1610: IsNotFound is set to false
            lookup_test.go:1614: error message is not equal to: no such host
            lookup_test.go:1628: unexpected error: lookup _ldap._tcp.google.com.: write /net/cs: cs: can't translate address: dns: resource does not exist; negrcode
--- FAIL: TestDNSErrorUnwrap (0.08s)
    lookup_test.go:1646: errors.Is(err, context.DeadlineExceeded) = false; want = true
    lookup_test.go:1651: errors.Is(err, context.Canceled) = false; want = true
    lookup_test.go:1658: errors.Is(err, context.Canceled) = false; want = true
FAIL
FAIL	net	248.333s
FAIL

See https://build.golang.org/log/277b08f6b641150f675b63ae10c674286d342f1a

CC @millerresearch
@0intro 0intro added this to the Go1.23 milestone Apr 28, 2024
@gopherbot
Copy link

Change https://go.dev/cl/582236 mentions this issue: net: fix lookupHost on Plan9

@0intro 0intro closed this as completed Apr 28, 2024
gopherbot pushed a commit that referenced this issue Apr 29, 2024
@0intro
net: fix lookupHost on Plan 9
16ce8b3 
CL 532217 added the newDNSError function.

However, the implementation was not correct on
Plan 9, which lead TestLookupNoSuchHost to fail.

This change fixes lookupHost on Plan 9.

Fixes #67096.

Change-Id: I39271f7d588b19c1b1608f18a24d871460be09cd
Reviewed-on: https://go-review.googlesource.com/c/go/+/582236
Reviewed-by: Joedian Reid <joedian@google.com>
Run-TryBot: David du Colombier <0intro@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-Plan9
Projects
None yet
Milestone
Go1.23
Development

No branches or pull requests
2 participants
@0intro @gopherbot