-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: add macOS security trybots to LUCI #67073
Comments
Change https://go.dev/cl/582095 mentions this issue: |
Change https://go.dev/cl/582096 mentions this issue: |
Change https://go.dev/cl/582036 mentions this issue: |
The next CL adds the darwin-amd64_14 builder type to the security trybot environment. I'd like it to have a known issue set to begin with, so add a SECURITY_KNOWN_ISSUE_BUILDER_TYPES dictionary and propagate it to make that possible. Some code rearrangement unfortunately happens to avoid "global variable referenced before assignment" errors. :( For golang/go#67073. Change-Id: I31d4354d0deadb944bae30cd0f07a85bb9c4e2e9 Reviewed-on: https://go-review.googlesource.com/c/build/+/582095 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com>
A new distinct set of VMs will be used for security pre-submit and release testing. Start with one builder with a known issue. For golang/go#67073. Change-Id: I86b1ed2ae238ca87666e00938b6b50af722f5b96 Reviewed-on: https://go-review.googlesource.com/c/build/+/582096 Reviewed-by: Michael Pratt <mpratt@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Change https://go.dev/cl/582558 mentions this issue: |
It needs read-only access to list bots in chrome-swarming, so it can know whether to launch or renew or destroy MacService leases. For golang/go#67073. Change-Id: Ida562721f4931b2309508e01b320605343fe90e9 Reviewed-on: https://go-review.googlesource.com/c/build/+/582558 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
For golang/go#67073. Change-Id: Ic80c778a624b1f68b3407ba16fcbd2d1ce61c0dd Reviewed-on: https://go-review.googlesource.com/c/build/+/582036 Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Change https://go.dev/cl/583116 mentions this issue: |
By now everything should be set up for it to work okay. For golang/go#67073. Change-Id: Ib0f2559b5e03706fe424fe3e6f2033a6ed3fa62f Reviewed-on: https://go-review.googlesource.com/c/build/+/583116 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com>
Change https://go.dev/cl/584775 mentions this issue: |
Change https://go.dev/cl/584404 mentions this issue: |
Now that the path is paved, add the remaining darwin-amd64 builders to the internal host. For golang/go#67073. Change-Id: I50d77f3f87d719f3b54a051e8bff929b00e168f3 Reviewed-on: https://go-review.googlesource.com/c/build/+/584404 Reviewed-by: Michael Pratt <mpratt@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
We have macOS builders in LUCI, but they're not yet available as security trybots. This is the tracking issue for that.
The text was updated successfully, but these errors were encountered: