Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: always assign code owners to a CL #66994

Closed
samthanawalla opened this issue Apr 23, 2024 · 2 comments
Closed

x/build/cmd/gopherbot: always assign code owners to a CL #66994

samthanawalla opened this issue Apr 23, 2024 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest
Milestone
Unreleased

Comments

@samthanawalla
Copy link
Contributor

Current Behavior

Code owners from https://dev.golang.org/owners are only assigned when no reviewers are assigned on a given CL.
This can create the unfortunate situation where some code owners are unaware of a CL if the author manually assigns a reviewer. The worst case is that no code owners will be aware of a change if the author manually assigns a non-owner.

Proposed behavior

At the minimum, always CC code owners to a CL even if there are sufficient human reviewers on a CL.
The change would take place here: https://cs.opensource.google/go/x/build/+/master:cmd/gopherbot/gopherbot.go;l=2116;bpv=0
@samthanawalla samthanawalla added Builders x/build issues (builders, bots, dashboards) FeatureRequest labels Apr 23, 2024
@samthanawalla samthanawalla self-assigned this Apr 23, 2024
@gopherbot gopherbot added this to the Unreleased milestone Apr 23, 2024
@samthanawalla samthanawalla removed their assignment Apr 23, 2024
@samthanawalla
Copy link
Contributor Author

https://go.dev/cl/571775

@dmitshur dmitshur changed the title x/cmd/build/gopherbot : always assign code owners to a CL x/build/cmd/gopherbot: always assign code owners to a CL Apr 23, 2024
@samthanawalla
Copy link
Contributor Author

Spoke with @dmitshur and he showed me that you can do this without gopherbot by setting watched changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @samthanawalla