New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/weak: remove unnecessary conversion, fix typo #66977
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: e3803c5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580936. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580936. |
Message from Dmitry Matrenichev: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580936. |
Remove unnecessary conversion from unsafe.Pointer to unsafe.Pointer. Also fix small typo in weak.Pointer.Strong method documentation.
This PR (HEAD: 7978d07) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580936. Important tips:
|
Message from Ian Lance Taylor: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/580936. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-23T17:39:17Z","revision":"46c22547a15193314090bcf5f0d5d7f5993421f7"} Please don’t reply on this GitHub thread. Visit golang.org/cl/580936. |
Message from Ian Lance Taylor: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/580936. |
Message from Go LUCI: Patch Set 3: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/580936. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/580936. |
Message from Ian Lance Taylor: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/580936. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-23T17:58:09Z","revision":"46c22547a15193314090bcf5f0d5d7f5993421f7"} Please don’t reply on this GitHub thread. Visit golang.org/cl/580936. |
Message from Michael Knyszek: Patch Set 3: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/580936. |
Message from Ian Lance Taylor: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/580936. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/580936. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/580936. |
Message from Joedian Reid: Patch Set 3: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/580936. |
Message from Dmitry Matrenichev: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580936. |
Remove unnecessary conversion from unsafe.Pointer to unsafe.Pointer. Also fix small typo in weak.Pointer.Strong method documentation. Change-Id: I84791fba244581bd6218c589827a61914f0797b4 GitHub-Last-Rev: 7978d07 GitHub-Pull-Request: #66977 Reviewed-on: https://go-review.googlesource.com/c/go/+/580936 Reviewed-by: Michael Knyszek <mknyszek@google.com> Commit-Queue: Ian Lance Taylor <iant@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Joedian Reid <joedian@google.com> Auto-Submit: Ian Lance Taylor <iant@golang.org>
This PR is being closed because golang.org/cl/580936 has been merged. |
Remove unnecessary conversion from unsafe.Pointer to unsafe.Pointer.
Also fix small typo in weak.Pointer.Strong method documentation.