New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor panic messages #66935
Refactor panic messages #66935
Conversation
%value -> %v value
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This PR (HEAD: b087f60) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580475. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580475. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/580475. |
"/reflect/all_test.go : refactor panic messages." This PR standardizes the capitalization and punctuation in panic messages within the reflect package. |
Message from Levandr: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580475. |
Message from Levandr: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580475. |
Message from Keith Randall: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/580475. |
This PR (HEAD: c54e33e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/580475. Important tips:
|
Message from Levandr: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580475. |
Message from Keith Randall: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580475. |
Message from Levandr: Patch Set 3: Code-Review+1 (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/580475. |
Message from Keith Randall: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/580475. |
"/reflect/all_test.go : refactor panic messages."
This PR standardizes the capitalization and punctuation in panic messages within the reflect package.
The changes ensure that panic messages are consistent with the Go coding standards and guidelines.
Specifically, this update modifies the capitalization and adds missing punctuation in panic error messages.