Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: deterministic fallback hashes across process boundary [1.22 backport] #66886

Closed
gopherbot opened this issue Apr 18, 2024 · 2 comments
Closed

runtime: deterministic fallback hashes across process boundary [1.22 backport] #66886

gopherbot opened this issue Apr 18, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.22.3

Comments

@gopherbot
Copy link

@prattmic requested issue #66885 to be considered for backport to the next 1.22 minor release.

@gopherbot Please backport to 1.22. This regression makes map hashes deterministic across processes.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 18, 2024
@gopherbot gopherbot mentioned this issue Apr 18, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Apr 18, 2024
@gopherbot gopherbot added this to the Go1.22.3 milestone Apr 18, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/580018 mentions this issue: [release-branch.go1.22] runtime: use bootstrapRand to initialize hashkey

@joedian joedian added the CherryPickApproved Used during the release process for point releases label Apr 24, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 24, 2024
gopherbot pushed a commit that referenced this issue Apr 26, 2024
@prattmic @joedian
[release-branch.go1.22] runtime: use bootstrapRand to initialize hashkey
3f4af1f 
The seed for rand is not initialized until after alginit. Before
initialization, rand returns a deterministic sequence, making hashkey
deterministic across processes.

Switch to bootstrapRand, like other early rand calls, such as
initialization of aeskeysched.

For #66885.
Fixes #66886.

Change-Id: I5023a9161232b49fda2ebd1d5f9338bbdd17b1fe
Reviewed-on: https://go-review.googlesource.com/c/go/+/580136
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
(cherry picked from commit 1a3682b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/580018
@gopherbot
Copy link
Author

Closed by merging 3f4af1f to release-branch.go1.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.22.3
Development

No branches or pull requests
2 participants
@gopherbot @joedian