Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: remove the "allowImplicitNetworkAccess" setting #66861

Open
findleyr opened this issue Apr 16, 2024 · 0 comments
Open

x/tools/gopls: remove the "allowImplicitNetworkAccess" setting #66861

findleyr opened this issue Apr 16, 2024 · 0 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

Following up on #66860, this issue tracks removing the "allowImplicitNetworkAccess" setting. As stated on that issue:

We should not have settings that affect low level behavior like this, as such settings are inevitably insufficiently tested and hard to maintain. Gopls should work well with its default decisions about allowing network access

If you are here because you use this setting and received a warning that it will be removed, please explain why you use it!

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 16, 2024
@gopherbot gopherbot added this to the Unreleased milestone Apr 16, 2024
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.17.0 Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants