Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: inline does not offer to inline nested call #66853

Closed
findleyr opened this issue Apr 16, 2024 · 1 comment
Closed

x/tools/gopls: inline does not offer to inline nested call #66853

findleyr opened this issue Apr 16, 2024 · 1 comment
Labels
gopls Issues related to the Go language server, gopls. Refactoring Issues related to refactoring tools Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.16.0

Comments

@findleyr
Copy link
Contributor

I just tried to use inlining on the following line of code:

	event.Log(ctx, viewEnv(v))

Gopls offered to inline the call to event.Log, but not the call to viewEnv, which is what I wanted. We should offer both.

CC @adonovan
@findleyr findleyr added the Refactoring Issues related to refactoring tools label Apr 16, 2024
@findleyr findleyr added this to the gopls/v0.16.0 milestone Apr 16, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 16, 2024
@findleyr
Copy link
Contributor Author

Whoops, this is my LSP client sending the entire line as the range, not the current cursor position.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Refactoring Issues related to refactoring tools Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.16.0
Development

No branches or pull requests
3 participants
@gopherbot @findleyr and others