New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: teach dse about equivalent LocalAddrs #66793
Conversation
This PR (HEAD: e15c9f7) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578376. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
Message from Derek Parker: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
Message from qiulaidongfeng: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-12T12:52:03Z","revision":"398eaa741327fce3eb9aa46db9784e5612fae9f0"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
Message from qiulaidongfeng: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
Message from Keith Randall: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
This PR (HEAD: 9e82095) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578376. Important tips:
|
Message from Derek Parker: Patch Set 4: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
Message from Keith Randall: Patch Set 4: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
Message from Keith Randall: Patch Set 4: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
This PR (HEAD: b80a6b2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/578376. Important tips:
|
Message from Derek Parker: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
Message from Keith Randall: Patch Set 5: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
Message from Go LUCI: Patch Set 5: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-24T15:36:32Z","revision":"2a561aaec86bb4ac756ca734d457dd79a68768e1"} Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
Message from Keith Randall: Patch Set 5: Auto-Submit+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
Message from Keith Randall: Patch Set 5: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
Message from Go LUCI: Patch Set 5: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
Message from Go LUCI: Patch Set 5: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/578376. |
This patch teaches DSE that two LocalAddrs of the same variable are equal, even if they are from different memory states. This avoids dependance on a store into the same LocalAddr being added to loadUse even though the store is unnecessary and is in fact shadowed. Fixes #59021 Change-Id: I0ef128b783c4ad6fd2236fa5ff20345b4d31eddb GitHub-Last-Rev: b80a6b2 GitHub-Pull-Request: #66793 Reviewed-on: https://go-review.googlesource.com/c/go/+/578376 Reviewed-by: Keith Randall <khr@golang.org> Auto-Submit: Keith Randall <khr@golang.org> Reviewed-by: Joedian Reid <joedian@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com>
This PR is being closed because golang.org/cl/578376 has been merged. |
This patch teaches DSE that two LocalAddrs of the same variable
are equal, even if they are from different memory states. This avoids
dependance on a store into the same LocalAddr being added to
loadUse even though the store is unnecessary and is in fact
shadowed.
Fixes #59021