Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/telemetry/cmd/gotelemetry: wrap output to 80 columns #66761

Open
rsc opened this issue Apr 10, 2024 · 2 comments
Open

x/telemetry/cmd/gotelemetry: wrap output to 80 columns #66761

rsc opened this issue Apr 10, 2024 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Milestone
Unreleased

Comments

@rsc
Copy link
Contributor

rsc commented Apr 10, 2024 

% gotelemetry on
Telemetry uploading is now enabled and data will be periodically sent to https://telemetry.go.dev/. Uploaded data is used to help improve the Go toolchain and related tools, and it will be published as part of a public dataset.

For more details, see https://telemetry.go.dev/privacy.
This data is collected in accordance with the Google Privacy Policy (https://policies.google.com/privacy).

To disable telemetry uploading, but keep local data collection, run “gotelemetry local”.
To disable both collection and uploading, run “gotelemetry off“.
%

Those are some very long lines. Here is a better output (also slightly reworded):

% gotelemetry on
Telemetry uploading is now enabled.
Data will be sent periodically to https://telemetry.go.dev/. 
Uploaded data is used to help improve the Go toolchain and related tools,
and it will be published as part of a public dataset.

For more details, see https://telemetry.go.dev/privacy.
This data is collected in accordance with the Google Privacy Policy 
(https://policies.google.com/privacy).

To disable telemetry uploading, but keep local data collection, run “gotelemetry local”.
To disable both collection and uploading, run “gotelemetry off“.
%
@gopherbot gopherbot added the telemetry x/telemetry issues label Apr 10, 2024
@gopherbot gopherbot added this to the Unreleased milestone Apr 10, 2024
@rsc
Copy link
Contributor Author

rsc commented Apr 10, 2024

Note that there is no need to do fancy wrapping or tty checks. Just hard-code something that looks reasonable in a reasonably-sized terminal.

@cagedmantis cagedmantis added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 11, 2024
@cagedmantis
Copy link
Contributor

@golang/telemetry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@rsc @cagedmantis @gopherbot