Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/talks: printout of slides does not include code #6676

Closed
rsc opened this issue Oct 27, 2013 · 7 comments
Closed

x/talks: printout of slides does not include code #6676

rsc opened this issue Oct 27, 2013 · 7 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@rsc
Copy link
Contributor

rsc commented Oct 27, 2013 

Visit http://talks.golang.org/2013/advconc.slide in Chrome
File > Print
Look through preview of printout: the code boxes are empty.
Cancel print.

Arrow-right until you get to a page with code boxes (like page #6).
See that they are filled in.

File > Print
Look through preview of printout: all code boxes, even after that page, now contain code.

It appears that something about flipping through the talk populates the code boxes on
demand? Perhaps this can be done at page load so that printing from slide 1 will work.


Google Chrome    30.0.1599.69 (Official Build 226629) 
OS  Mac OS X 
Blink   537.36 (@158213)
JavaScript  V8 3.20.17.13
Flash    11.9.900.117
User Agent  Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_5) AppleWebKit/537.36 (KHTML,
like Gecko) Chrome/30.0.1599.69 Safari/537.36
Command Line     /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
-psn_0_20652977 --flag-switches-begin --flag-switches-end
Executable Path /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
@rsc
Copy link
Contributor Author

rsc commented Oct 27, 2013

Comment 1:

Labels changed: added priority-later, removed priority-triage.

@adg
Copy link
Contributor

adg commented Nov 8, 2013

Comment 2:

Can you still see the problem Russ? I think Chrome may have fixed this. I can't
reproduce the issue anymore in Chrome or Safari.

Status changed to WaitingForReply.

@adg
Copy link
Contributor

adg commented Nov 8, 2013

Comment 3:

I am mistaken. I mis-tested.

Status changed to Accepted.

@rsc
Copy link
Contributor Author

rsc commented Nov 27, 2013

Comment 4:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor Author

rsc commented Dec 4, 2013

Comment 5:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor Author

rsc commented Dec 4, 2013

Comment 6:

Labels changed: added repo-talks.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title go.talks: printout of slides does not include code x/talks: printout of slides does not include code Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-talks label Apr 14, 2015
@ALTree
Copy link
Member

ALTree commented Feb 2, 2017

Looks like this is fixed; now (tested with Chromium 55) the code snippets show up in the print preview.

@ALTree ALTree closed this as completed Feb 2, 2017
@golang golang locked and limited conversation to collaborators Feb 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@rsc @ALTree @adg @gopherbot