Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: test timeouts on the linux-ppc64le-power9osu builder #66748

Closed
gopherbot opened this issue Apr 9, 2024 · 5 comments
Closed

x/tools/gopls: test timeouts on the linux-ppc64le-power9osu builder #66748

gopherbot opened this issue Apr 9, 2024 · 5 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.16.0

Comments

@gopherbot
Copy link

gopherbot commented Apr 9, 2024 •
edited by findleyr 

#!watchflakes
default <- pkg ~ `golang.org/x/tools/gopls/internal/test/integration.*` && builder == "linux-ppc64le-power9osu"

Issue created automatically to collect these failures.

Example (log):

#### Start Gopls Test Logs for "TestClosingBuffer/default"
[Trace - 15:07:21.975 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fake.Editor","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator","label"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"0s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-test-3388857193/TestClosingBuffer/default/gopath","GOPROXY":"file:///workdir/tmp/gopls-test-3388857193/TestClosingBuffer/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-test-3388857193/TestClosingBuffer/default/work","name":"work"}]}


[Trace - 15:07:21.975 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.add_telemetry_counters","gopls.apply_fix","gopls.change_signature","gopls.check_upgrades","gopls.diagnose_files","gopls.doc","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.maybe_prompt_for_telemetry","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_go_work_command","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.start_profile","gopls.stop_profile","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor","gopls.views","gopls.workspace_stats"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator","label"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 9f3f4c64dbfd37ef9f7113708a706a8099d72fd9\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"(unknown)\"}"}}


[Trace - 15:07:21.976 PM] Sending notification 'initialized'.
...
panic: test timed out after 20m0s
running tests:
	TestClosingBuffer (26s)
	TestClosingBuffer/default (26s)

testing.(*T).Run(0xc003b6b860, {0xc771cc?, 0xc9c28f?}, 0xc0019ea1e0)
	/workdir/go/src/testing/testing.go:1750 +0x3a4
golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run(0xc00039d9a0, 0xc003b6b860, {0xcfc328, 0x51}, 0xe28228, {0x0, 0x0, 0x16bd4c?})
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:172 +0x4a8
golang.org/x/tools/gopls/internal/test/integration.Run(...)
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/regtest.go:56
golang.org/x/tools/gopls/internal/test/integration/diagnostics.TestClosingBuffer(0xc003b6b860?)
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/diagnostics/diagnostics_test.go:1098 +0x60
testing.tRunner(0xc003b6b860, 0xe27e70)

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 9, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/diagnostics" && test == "TestClosingBuffer"
2024-04-09 14:12 linux-ppc64le-power9osu tools@3520955d go@9f3f4c64 x/tools/gopls/internal/test/integration/diagnostics.TestClosingBuffer (log) 
#### Start Gopls Test Logs for "TestClosingBuffer/default"
[Trace - 15:07:21.975 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fake.Editor","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator","label"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"0s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-test-3388857193/TestClosingBuffer/default/gopath","GOPROXY":"file:///workdir/tmp/gopls-test-3388857193/TestClosingBuffer/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-test-3388857193/TestClosingBuffer/default/work","name":"work"}]}


[Trace - 15:07:21.975 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.add_telemetry_counters","gopls.apply_fix","gopls.change_signature","gopls.check_upgrades","gopls.diagnose_files","gopls.doc","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.maybe_prompt_for_telemetry","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_go_work_command","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.start_profile","gopls.stop_profile","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor","gopls.views","gopls.workspace_stats"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator","label"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 9f3f4c64dbfd37ef9f7113708a706a8099d72fd9\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"(unknown)\"}"}}


[Trace - 15:07:21.976 PM] Sending notification 'initialized'.
...
panic: test timed out after 20m0s
running tests:
	TestClosingBuffer (26s)
	TestClosingBuffer/default (26s)

testing.(*T).Run(0xc003b6b860, {0xc771cc?, 0xc9c28f?}, 0xc0019ea1e0)
	/workdir/go/src/testing/testing.go:1750 +0x3a4
golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run(0xc00039d9a0, 0xc003b6b860, {0xcfc328, 0x51}, 0xe28228, {0x0, 0x0, 0x16bd4c?})
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:172 +0x4a8
golang.org/x/tools/gopls/internal/test/integration.Run(...)
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/regtest.go:56
golang.org/x/tools/gopls/internal/test/integration/diagnostics.TestClosingBuffer(0xc003b6b860?)
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/diagnostics/diagnostics_test.go:1098 +0x60
testing.tRunner(0xc003b6b860, 0xe27e70)

— watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Apr 9, 2024
This was referenced Apr 9, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@findleyr findleyr changed the title x/tools/gopls/internal/test/integration/diagnostics: TestClosingBuffer failures x/tools/gopls: test timeouts on the linux-ppc64le-power9osu builder Apr 9, 2024
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.16.0 Apr 9, 2024
@gopherbot
Copy link
Author

Sorry, but there were parse errors in the watch flakes script.
The script I found was:

#!watchflakes
default <- pkg ~ "golang.org/x/tools/gopls/internal/test/integration.*" && builder == "linux-ppc64le-power9osu"

And the problems were:

script:2.18: ~ requires backquoted regexp

See https://go.dev/wiki/Watchflakes for details.

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg ~ `golang.org/x/tools/gopls/internal/test/integration.*` && builder == "linux-ppc64le-power9osu"
2024-04-09 14:12 linux-ppc64le-power9osu tools@3520955d go@a65a2bbd x/tools/gopls/internal/test/integration/diagnostics.TestProgressBarErrors (log) 
#### Start Gopls Test Logs for "TestProgressBarErrors/default"
[Trace - 15:00:55.989 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fake.Editor","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator","label"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"0s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-test-2274557195/TestProgressBarErrors/default/gopath","GOPROXY":"file:///workdir/tmp/gopls-test-2274557195/TestProgressBarErrors/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-test-2274557195/TestProgressBarErrors/default/work","name":"work"}]}


[Trace - 15:00:55.989 PM] Received response 'initialize - (1)' in 0ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.add_telemetry_counters","gopls.apply_fix","gopls.change_signature","gopls.check_upgrades","gopls.diagnose_files","gopls.doc","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.maybe_prompt_for_telemetry","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_go_work_command","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.start_profile","gopls.stop_profile","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor","gopls.views","gopls.workspace_stats"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator","label"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.22.2\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"(unknown)\"}"}}


[Trace - 15:00:55.990 PM] Sending notification 'initialized'.
...
panic: test timed out after 20m0s
running tests:
	TestProgressBarErrors (10s)
	TestProgressBarErrors/default (10s)

testing.(*T).Run(0xc00117a4e0, {0xc651a1?, 0xc8a372?}, 0xc005392190)
	/workdir/go/src/testing/testing.go:1750 +0x3a4
golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run(0xc00011cdc0, 0xc00117a4e0, {0xce2a86, 0x40}, 0xe16508, {0x0, 0x0, 0x16a15c?})
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:172 +0x4a8
golang.org/x/tools/gopls/internal/test/integration.Run(...)
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/regtest.go:56
golang.org/x/tools/gopls/internal/test/integration/diagnostics.TestProgressBarErrors(0xc00117a4e0?)
	/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/diagnostics/diagnostics_test.go:1542 +0x60
testing.tRunner(0xc00117a4e0, 0xe16120)

— watchflakes

@findleyr findleyr mentioned this issue Apr 10, 2024
Closed
@findleyr
Copy link
Contributor

CC @golang/ppc64 @golang/release

I'm going to disable the gopls integration tests on this builder. It seems that they take too long.

@gopherbot
Copy link
Author

Change https://go.dev/cl/577795 mentions this issue: gopls/internal/test: skip integration tests on linux-ppc64-power9osu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
gopls/v0.16.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr