Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: x/tools/go/analysis: register debug flag in analysistest.Run #66745

Open
mneverov opened this issue Apr 9, 2024 · 3 comments
Open

proposal: x/tools/go/analysis: register debug flag in analysistest.Run #66745

mneverov opened this issue Apr 9, 2024 · 3 comments
Labels
Proposal
Milestone
Proposal

Comments

@mneverov
Copy link

mneverov commented Apr 9, 2024

Proposal Details

Currently, flags for analysis driver are registered in an internal package and are used in the Main function that runs analysis.
It would be nice to register flags in analysistest.Run and RunWithSuggestedFixes. I am interested in particular in the debug flag that allows to run analyzer sequentially, that simplifies debugging tests.

Other issues I found and red regarding flags #65776, #53215, and #32155.
@gopherbot gopherbot added this to the Proposal milestone Apr 9, 2024
@ianlancetaylor
Copy link
Contributor

CC @golang/tools-team

@adonovan
Copy link
Member

adonovan commented Apr 9, 2024

Would this API #61324, in particular, the Sequential flag, address your need?

If so, I'll bring that change back up to date and finally merge it.

@mneverov
Copy link
Author

mneverov commented Apr 9, 2024

@adonovan the proposal looks great! Looking forward to it to be merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Proposal
Projects
Proposals
Status: Incoming
Milestone
Proposal
Development

No branches or pull requests
4 participants
@mneverov @ianlancetaylor @adonovan @gopherbot