Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/text/cmd/gotext: extract extreme slow #66742

Closed
okhowang opened this issue Apr 9, 2024 · 4 comments
Closed

x/text/cmd/gotext: extract extreme slow #66742

okhowang opened this issue Apr 9, 2024 · 4 comments
Milestone

Comments

@okhowang
Copy link

okhowang commented Apr 9, 2024

Go version

go version go1.22.1 windows/amd64

Output of go env in your module/workspace:

set GO111MODULE=on
set GOARCH=amd64
set GOBIN=
set GOCACHE=Z:\go-build
set GOENV=C:\Users\okhowang\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=Z:\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=Z:\go
set GOPRIVATE=
set GOPROXY=direct
set GOROOT=C:/Program Files/Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLCHAIN=auto
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.22.1
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=0
set GOMOD=D:\workspace\golang\text\go.mod
set GOWORK=
set CGO_CFLAGS=-O2 -g
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-O2 -g
set CGO_FFLAGS=-O2 -g
set CGO_LDFLAGS=-O2 -g
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=C:\Users\okhowang\AppData\Local\Temp\go-build15672011=/tmp/go-build -gno-record-gcc-switches

What did you do?

git clone https://github.com/ory/fosite.git
cd fosite
gotext update -out catalog.go .

What did you see happen?

gotext update run slowly.

What did you expect to see?

gotext done in a reasonable duration

@gopherbot gopherbot added this to the Unreleased milestone Apr 9, 2024
@okhowang
Copy link
Author

okhowang commented Apr 9, 2024

I try replace loader api to packages api
okhowang/text@639ea0f
and it seems like faster.

@seankhliao seankhliao changed the title x/text/message: extract extreme slow x/text/cmd/gotext: extract extreme slow Apr 9, 2024
@seankhliao
Copy link
Member

What counts as slow? For me it took 9s:

$ time gotext update -out catalog.go .
gotext update -out catalog.go .  69.23s user 22.39s system 1035% cpu 8.851 total

@seankhliao
Copy link
Member

Duplicate of #49039

@seankhliao seankhliao marked this as a duplicate of #49039 Apr 9, 2024
@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2024
@okhowang
Copy link
Author

@seankhliao is gotext accept contribution currently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants