Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: add LUCI wasip1-wasm32_wasmtime builder #66711

Open
johanbrandhorst opened this issue Apr 7, 2024 · 3 comments
Open

x/build: add LUCI wasip1-wasm32_wasmtime builder #66711

johanbrandhorst opened this issue Apr 7, 2024 · 3 comments
Assignees
@johanbrandhorst
Labels
Builders x/build issues (builders, bots, dashboards) new-builder
Milestone
Unreleased

Comments

@johanbrandhorst
Copy link
Member

As part of the work on the wasm32 architecture, we'd like to add a new builder for running the wasip1 tests. This builder will need to have wasmtime installed and set the following environment variables:

GOOS=wasip1
GOARCH=wasm
GOWASIRUNTIME=wasmtime
PATH=$PATH:/workdir/go/misc/wasm
GO_DISABLE_OUTBOUND_NETWORK=1

CC @dmitshur
@johanbrandhorst johanbrandhorst self-assigned this Apr 7, 2024
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Apr 7, 2024
@gopherbot gopherbot added this to the Unreleased milestone Apr 7, 2024
@johanbrandhorst
Copy link
Member Author

CC @golang/wasm

@dmitshur
Copy link
Contributor

dmitshur commented Apr 7, 2024

Thanks. Confirming a few details.

GOARCH should be wasm32 instead of wasm, is that right?

Related to the above—will GOROOT/misc/wasm be used for both wasm and wasm32 exec helpers? That seems good to me, just confirming.

GO_DISABLE_OUTBOUND_NETWORK is an internal implementation detail of the old build system, no need to set it for this builder in LUCI.

If the above is right, the definition of this builder in main.star will be very similar to the wasip1-wasm_wasmtime builder. There'll be a few places to consider wasm32 architecture value in addition to wasm, both in main.star (e.g., here and here) and in golangbuild (e.g., here), maybe by checking for their common "wasm" prefix.

@dmitshur dmitshur changed the title x/build: add LUCI wasip1-wasm32-wasmtime builder x/build: add LUCI wasip1-wasm32_wasmtime builder Apr 7, 2024
@johanbrandhorst
Copy link
Member Author

GOARCH should be wasm32 instead of wasm, is that right?

Yes

Related to the above—will GOROOT/misc/wasm be used for both wasm and wasm32 exec helpers? That seems good to me, just confirming.

Yes

GO_DISABLE_OUTBOUND_NETWORK is an internal implementation detail of the old build system, no need to set it for this builder in LUCI.

OK, great, I was unsure about that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johanbrandhorst johanbrandhorst

Labels
Builders x/build issues (builders, bots, dashboards) new-builder
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @johanbrandhorst @gopherbot