Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types: optimize use of method sets #6669

Closed
griesemer opened this issue Oct 25, 2013 · 4 comments
Closed

go/types: optimize use of method sets #6669

griesemer opened this issue Oct 25, 2013 · 4 comments
Labels
FrozenDueToAge
Milestone
Unplanned

Comments

@griesemer
Copy link
Contributor 

- method sets should always compute both the set for a type T and *T
- method sets should be used for some of the internal lookup operations
- method sets should be computed at most once
@rsc
Copy link
Contributor

rsc commented Nov 27, 2013

Comment 1:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 2:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 3:

Labels changed: added repo-tools.

@griesemer griesemer self-assigned this Dec 4, 2013
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title go.tools/go/types: optimize use of method sets x/tools/go/types: optimize use of method sets Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-tools label Apr 14, 2015
@griesemer griesemer modified the milestones: Unplanned, Unreleased Jun 23, 2015
@griesemer griesemer changed the title x/tools/go/types: optimize use of method sets go/types: optimize use of method sets Jun 23, 2015
@griesemer
Copy link
Contributor Author

Closing due to age. If there's an actual performance issue we would have seen it by now.

@golang golang locked and limited conversation to collaborators Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@rsc @griesemer @gopherbot