New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expvar: add the missing deletion step for keys #66675

Closed

apocelipes wants to merge 1 commit into golang:master from apocelipes:fix-expvar-deletion

Contributor

apocelipes commented Apr 4, 2024

In CL575777 I forgot to remove the key from the "sync.Map".
This did not cause the test to fail due to the lack of an associated
testcase. Now delete the key correctly and add the testcase.


          expvar: add the missing deletion step for keys

a351ce0

In CL575777 I forgot to remove the key from the "sync.Map".
This did not cause the test to fail due to the lack of an
associated testcase. Now delete the key correctly and add the
testcase.

gopherbot commented Apr 4, 2024

This PR (HEAD: a351ce0) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/576395.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot commented Apr 4, 2024

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/576395.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

Message from kyose chang:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/576395.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

Message from qiulaidongfeng:

Patch Set 1: Code-Review+1 Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/576395.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-04T11:40:08Z","revision":"37185193a95ea5b5f4cf8288fa4fdd2cf4a54a8b"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/576395.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

Message from qiulaidongfeng:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/576395.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/576395.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/576395.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          expvar: add the missing deletion step for keys

0f10ffe

In CL575777 I forgot to remove the key from the "sync.Map".
This did not cause the test to fail due to the lack of an associated
testcase. Now delete the key correctly and add the testcase.

Change-Id: I26f770966a828caa02f1766675756b67894dc195
GitHub-Last-Rev: a351ce0
GitHub-Pull-Request: #66675
Reviewed-on: https://go-review.googlesource.com/c/go/+/576395
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: qiu laidongfeng2 <2645477756@qq.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@google.com>

gopherbot commented Apr 4, 2024

Message from Keith Randall:

Patch Set 1: Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/576395.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

Message from Keith Randall:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/576395.
After addressing review feedback, remember to publish your drafts!

gopherbot commented Apr 4, 2024

This PR is being closed because golang.org/cl/576395 has been merged.

gopherbot closed this

apocelipes deleted the fix-expvar-deletion branch

April 18, 2024 16:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment