New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expvar: use slices to simplify the code #66660
Conversation
This PR (HEAD: 24cb939) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/575777. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/575777. |
Message from kyose chang: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/575777. |
Message from Keith Randall: Patch Set 1: Code-Review+2 Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/575777. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-03T15:39:09Z","revision":"b4aecc8596115396362eb5f5c32fcb474441ec85"} Please don’t reply on this GitHub thread. Visit golang.org/cl/575777. |
Message from Keith Randall: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/575777. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/575777. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/575777. |
24cb939
to
5801b30
Compare
This PR (HEAD: 5801b30) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/575777. Important tips:
|
Message from kyose chang: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/575777. |
Message from Ian Lance Taylor: Patch Set 2: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/575777. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-04-03T20:43:20Z","revision":"9894af844d3c980cf0842d3487e92927b6ddc10c"} Please don’t reply on this GitHub thread. Visit golang.org/cl/575777. |
Message from Ian Lance Taylor: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/575777. |
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/575777. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/575777. |
No effect on benchmarks. Change-Id: I7454c21b25d5e44b9c4a39922ed470522f81872d GitHub-Last-Rev: 5801b30 GitHub-Pull-Request: #66660 Reviewed-on: https://go-review.googlesource.com/c/go/+/575777 Reviewed-by: Keith Randall <khr@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: Keith Randall <khr@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com>
This PR is being closed because golang.org/cl/575777 has been merged. |
No effect on benchmarks.