Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: lib/godoc/analysis/help page unreadable with dark theme #66659

Open
xieyuschen opened this issue Apr 3, 2024 · 2 comments
Open

x/website: lib/godoc/analysis/help page unreadable with dark theme #66659

xieyuschen opened this issue Apr 3, 2024 · 2 comments
Labels
help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website
Milestone
website/unplanned

Comments

@xieyuschen
Copy link

What is the URL of the page with the issue?

https://go.dev/lib/godoc/analysis/help

What is your user agent?

Safiri and Chrome

Screenshot

image

What did you do?

normal open the site and view it directly

What did you see happen?

markdown files unreadable with dark theme

What did you expect to see?

i want to see the normal rendered page under dark theme

this issue is the same issue as #64929
@gopherbot gopherbot added this to the Unreleased milestone Apr 3, 2024
@xieyuschen xieyuschen mentioned this issue Apr 3, 2024
Open
@hyangah
Copy link
Contributor

hyangah commented Apr 4, 2024

The source of this page https://github.com/golang/website/blob/master/_content/lib/godoc/analysis/help.html is html (not markdown), and the images are png files. This page doesn't render well anyway. Can we remove the style in the html and also convert to markdown?

@hyangah hyangah added NeedsFix The path to resolution is known, but the work has not been done. help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed pkgsite NeedsFix The path to resolution is known, but the work has not been done. labels Apr 4, 2024
@hyangah hyangah modified the milestones: Unreleased, website/unplanned Apr 4, 2024
@hyangah hyangah changed the title x/website: markdown files unreadable with dark theme x/website: lib/godoc/analysis/help page unreadable with dark theme Apr 4, 2024
@xieyuschen
Copy link
Author

The source of this page https://github.com/golang/website/blob/master/_content/lib/godoc/analysis/help.html is html (not markdown), and the images are png files. This page doesn't render well anyway. Can we remove the style in the html and also convert to markdown?

The html doesn't matter if the template is added, as i verified it in my local. I use website@b5fc39c6 to try.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website
Projects
None yet
Milestone
website/unplanned
Development

No branches or pull requests
3 participants
@hyangah @gopherbot @xieyuschen