Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/json: optimize tagOptions.Contains #66644

Closed
wants to merge 1 commit into from
Closed

encoding/json: optimize tagOptions.Contains #66644

wants to merge 1 commit into from

Conversation

apocelipes
Copy link
Contributor

The new code is about 18% faster.

Here is the benchmark highlights:

goos: windows
goarch: amd64
pkg: encoding/json
cpu: Intel(R) Core(TM) i5-10200H CPU @ 2.40GHz
│ old.bench │ new.bench │
│ sec/op │ sec/op vs base │
TagOptionsContains-8 17.07n ± 1% 13.87n ± 3% -18.78% (p=0.000 n=10)

@apocelipes
encoding/json: optimize tagOptions.Contains
03acefa 
The new code is about 18% faster.

Here is the benchmark highlights:

goos: windows
goarch: amd64
pkg: encoding/json
cpu: Intel(R) Core(TM) i5-10200H CPU @ 2.40GHz
                     │  old.bench  │              new.bench              │
                     │   sec/op    │   sec/op     vs base                │
TagOptionsContains-8   17.07n ± 1%   13.87n ± 3%  -18.78% (p=0.000 n=10)
@gopherbot
Copy link

This PR (HEAD: 03acefa) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/575439.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/575439.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from kyose chang:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/575439.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Daniel Martí:

Patch Set 1: Hold+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/575439.
After addressing review feedback, remember to publish your drafts!

@apocelipes apocelipes closed this Apr 2, 2024
@apocelipes apocelipes deleted the optimize-tag-contains branch April 18, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apocelipes @gopherbot