New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
database/sql: use slices to simplify the code #66572
database/sql: use slices to simplify the code #66572
Conversation
This PR (HEAD: cd45ae5) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574995. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from kyose chang: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from qiulaidongfeng: Patch Set 1: Code-Review+1 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-28T13:05:42Z","revision":"d5fa11692d3344f966d303c510ad36a90a19930c"} Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from qiulaidongfeng: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Go LUCI: Patch Set 1: This CL has failed the run. Reason: Tryjob golang/try/gotip-windows-386 has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links:
Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
cd45ae5
to
6202364
Compare
This PR (HEAD: 6202364) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574995. Important tips:
|
Message from kyose chang: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Ian Lance Taylor: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
6202364
to
c2f958e
Compare
This PR (HEAD: c2f958e) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574995. Important tips:
|
Message from kyose chang: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Ian Lance Taylor: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from kyose chang: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
90bff5b
to
d44d83c
Compare
This PR (HEAD: 90bff5b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574995. Important tips:
|
Message from kyose chang: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
This PR (HEAD: d44d83c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574995. Important tips:
|
Message from Ian Lance Taylor: Patch Set 5: (4 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
d44d83c
to
ba4d80c
Compare
This PR (HEAD: ba4d80c) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574995. Important tips:
|
Message from kyose chang: Patch Set 6: (5 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Ian Lance Taylor: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
ba4d80c
to
e713ac3
Compare
This PR (HEAD: e713ac3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/574995. Important tips:
|
Message from kyose chang: Patch Set 6: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Ian Lance Taylor: Patch Set 7: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Go LUCI: Patch Set 7: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-29T20:59:59Z","revision":"dd53a36138011b70eccba7967f529f349eab3fb2"} Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Ian Lance Taylor: Patch Set 7: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Go LUCI: Patch Set 7: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Go LUCI: Patch Set 7: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Ian Lance Taylor: Patch Set 7: Auto-Submit+1 Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Go LUCI: Patch Set 7: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-29T22:59:58Z","revision":"dd53a36138011b70eccba7967f529f349eab3fb2"} Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Ian Lance Taylor: Patch Set 7: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Go LUCI: Patch Set 7: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-amd64-boringcrypto has failed with summary (view all results): FAILURE
Tests failed. See all test results. Error: Links: Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Go LUCI: Patch Set 7: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from kyose chang: Patch Set 7: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from qiulaidongfeng: Patch Set 7: Code-Review+1 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Go LUCI: Patch Set 7: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-03-30T03:31:36Z","revision":"dd53a36138011b70eccba7967f529f349eab3fb2"} Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from qiulaidongfeng: Patch Set 7: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Go LUCI: Patch Set 7: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Go LUCI: Patch Set 7: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Message from Emmanuel Odeke: Patch Set 7: Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
Change-Id: Ia198272330626271ee7d4e1ae46afca819ab2933 GitHub-Last-Rev: e713ac3 GitHub-Pull-Request: #66572 Reviewed-on: https://go-review.googlesource.com/c/go/+/574995 Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com> Reviewed-by: Ian Lance Taylor <iant@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Than McIntosh <thanm@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: qiulaidongfeng <2645477756@qq.com>
Message from Than McIntosh: Patch Set 7: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/574995. |
This PR is being closed because golang.org/cl/574995 has been merged. |
No description provided.