Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: func Test doesn't work in module mode: function main is undeclared #66451

Open
dolmen opened this issue Mar 21, 2024 · 2 comments
Open

x/playground: func Test doesn't work in module mode: function main is undeclared #66451

dolmen opened this issue Mar 21, 2024 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@dolmen
Copy link
Contributor

dolmen commented Mar 21, 2024 •
edited

func Test(*testing.T) is not executed on https://go.dev/play when a go.mod file is provided.

What did you do?

This doesn't run: https://go.dev/play/p/ZDFf4aGucoB

package main

import (
	"testing"

	"github.com/stretchr/testify/assert"
)

func Test(t *testing.T) {
	assert.True(t, true)
}
-- go.mod --
module play.ground

require github.com/stretchr/testify v1.9.0

What did you see happen?

Output:

go: downloading github.com/stretchr/testify v1.9.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading gopkg.in/yaml.v3 v3.0.1
# play.ground
runtime.main_main·f: function main is undeclared in the main package

What did you expect to see?

If I remove the go.mod, it runs correctly.

Example: https://go.dev/play/p/AsRNcxCRdWx

=== RUN   Test
--- PASS: Test (0.00s)
PASS
@gopherbot gopherbot added this to the Unreleased milestone Mar 21, 2024
@dolmen dolmen changed the title x/playground: Test function doesn't work in module mode: function main is undeclared x/playground: func Test doesn't work in module mode: function main is undeclared Mar 21, 2024
@dr2chase dr2chase added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 25, 2024
@dr2chase
Copy link
Contributor

I am not sure this is a bug, there is in fact no main function in the main package.
Not-module-mode is now a special case, at least as I understand it.

@rsc (for go/build) and @golang/tools-team (for the playground).

@dolmen
Copy link
Contributor Author

dolmen commented Mar 26, 2024

Reproducible builds on the Go playground (enforced by locking dependencies with go.mod) are an important feature (even if still underused) to help bug reporters to demonstrate issues. A func(*testing.T) is a good way to convey that as the code provided can easily be integrated in a test suite.

This may not qualify as "bug" but "feature request" or "proposal", but I argue it is an important feature for the Go community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dolmen @dr2chase @gopherbot