Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website/_content/doc: wrong branch names in install from source docs #66448

Closed
andrewbaptist opened this issue Mar 21, 2024 · 4 comments
Closed

x/website/_content/doc: wrong branch names in install from source docs #66448

andrewbaptist opened this issue Mar 21, 2024 · 4 comments
Labels
Documentation help wanted NeedsFix The path to resolution is known, but the work has not been done. website
Milestone
website/unplanned

Comments

@andrewbaptist
Copy link

What is the URL of the page with the issue?

https://go.dev/doc/install/source

Screenshot

image

What did you do?

It says "check out the latest release tag (go1.12, for example)", it should probably say "check out the latest release tag (release-branch.go1.12, for example)" instead.

What did you expect to see?

Attempting to follow the docs:

% git checkout go1.22
error: pathspec 'go1.22' did not match any file(s) known to git

Actual necessary command:

% git checkout release-branch.go1.22
branch 'release-branch.go1.22' set up to track 'origin/release-branch.go1.22'.
Switched to a new branch 'release-branch.go1.22'
@gopherbot gopherbot added this to the Unreleased milestone Mar 21, 2024
@seankhliao seankhliao changed the title x/website: clean up branch names x/website/_content/doc: wrong branch names in install from source docs Mar 21, 2024
@seankhliao seankhliao added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 21, 2024
@go101
Copy link

go101 commented Mar 21, 2024

There is not a go1.22 tag, try go1.22.0 or go1.22.1 please.

@adonovan
Copy link
Member

As @go101 says, a patch suffix is required. The docs should certainly be updated to state this, or give better alternative instructions.

@andrewbaptist
Copy link
Author

Thanks!

I had missed the tags, and only looked at branches. It probably is worth clarifying, but I didn't really have a problem solving it, it was more to help anyone else.

@qiulaidongfeng qiulaidongfeng mentioned this issue Mar 22, 2024
Closed
@gopherbot
Copy link

Change https://go.dev/cl/573735 mentions this issue: website/_content/doc: add goroot tag example

@hyangah hyangah modified the milestones: Unreleased, website/unplanned Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation help wanted NeedsFix The path to resolution is known, but the work has not been done. website
Projects
None yet
Milestone
website/unplanned
Development

Successfully merging a pull request may close this issue.

website/_content/doc: add goroot tag example qiulaidongfeng/website
6 participants
@hyangah @adonovan @gopherbot @seankhliao @go101 @andrewbaptist