Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slices: add examples #66435

Closed
callthingsoff opened this issue Mar 21, 2024 · 1 comment
Closed

slices: add examples #66435

callthingsoff opened this issue Mar 21, 2024 · 1 comment
Labels
NeedsFix The path to resolution is known, but the work has not been done.

Comments

@callthingsoff
Copy link
Contributor

Go version

not related

Output of go env in your module/workspace:

not related

What did you do?

It seems that the slices package currently does not have examples for the following APIs:
Clone, Grow, Clip, Concat, Contains, Repeat.
I'm not sure if they should be added.

What did you see happen?

There are no examples for Clone, Grow, Clip, Concat, Contains, Repeat.

What did you expect to see?

Maybe add examples for those APIs.
@gopherbot
Copy link

Change https://go.dev/cl/573255 mentions this issue: slices: add examples

@dr2chase dr2chase added the NeedsFix The path to resolution is known, but the work has not been done. label Mar 21, 2024
Mchnan pushed a commit to Mchnan/go-sylixos that referenced this issue Mar 28, 2024
@callthingsoff
slices: add examples
d924271 
For Clone, Grow, Clip, Concat, Contains, Repeat.

Fixes golang#66435

Change-Id: Ife8f61427e9cd18b7106c100de8f82f9d7840c9b
Reviewed-on: https://go-review.googlesource.com/c/go/+/573255
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drchase@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dr2chase @callthingsoff @gopherbot