Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/rc4: rc4_ref.go does not compile #6642

Closed
rsc opened this issue Oct 22, 2013 · 8 comments
Closed

crypto/rc4: rc4_ref.go does not compile #6642

rsc opened this issue Oct 22, 2013 · 8 comments
Labels
FrozenDueToAge
Milestone
Go1.3

Comments

@rsc
Copy link
Contributor

rsc commented Oct 22, 2013 

That is:

1. rc4_ref.go is not used in any builds (it only builds on non-amd64, non-386, non-arm).
2. rc4_ref.go contains type errors.

We should shuffle things around so the code is built and tested (but then not linked
into real binaries), or we should delete the file.
@bradfitz
Copy link
Contributor

Comment 1:

What does gccgo use here on non-amd64, non-386, non-arm?

@ianlancetaylor
Copy link
Contributor

Comment 2:

I fixed rc4_ref.go, hopefully correctly.
https://code.google.com/p/gofrontend/source/browse/libgo/go/crypto/rc4/rc4_ref.go

@rsc
Copy link
Contributor Author

rsc commented Dec 4, 2013

Comment 3:

Labels changed: added release-go1.3.

@rsc
Copy link
Contributor Author

rsc commented Dec 4, 2013

Comment 4:

Labels changed: removed go1.3.

@rsc
Copy link
Contributor Author

rsc commented Dec 4, 2013

Comment 5:

Labels changed: added repo-main.

@rsc
Copy link
Contributor Author

rsc commented Dec 18, 2013

Comment 6:

3895ad0afefe fixed rc4_ref but there is still no test.

@bradfitz
Copy link
Contributor

Comment 7:

Owner changed to @bradfitz.

Status changed to Started.

@bradfitz
Copy link
Contributor

Comment 8:

This issue was closed by revision a7fb318.

Status changed to Fixed.

@rsc rsc added fixed labels Feb 18, 2014
@rsc rsc added this to the Go1.3 milestone Apr 14, 2015
@rsc rsc removed the release-go1.3 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.3
Development

No branches or pull requests
4 participants
@bradfitz @rsc @ianlancetaylor @gopherbot