Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: bad carrier sym for symbol runtime.elf_savegpr0.args_stackmap on ppc64le [1.22 backport] #66412

Closed
gopherbot opened this issue Mar 19, 2024 · 2 comments
Closed

cmd/link: bad carrier sym for symbol runtime.elf_savegpr0.args_stackmap on ppc64le [1.22 backport] #66412

gopherbot opened this issue Mar 19, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.22.2

Comments

@gopherbot
Copy link

@pmur requested issue #66265 to be considered for backport to the next 1.22 minor release.

@gopherbot please consider a backport for go 1.21 and go 1.22 as this prevents building certain cgo applications as PIE binaries.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 19, 2024
@gopherbot gopherbot mentioned this issue Mar 19, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Mar 19, 2024
@gopherbot gopherbot added this to the Go1.22.2 milestone Mar 19, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/572875 mentions this issue: [release-branch.go1.22] cmd/internal/obj/ppc64: don't modify runtime.elf_* symbols

@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label Mar 20, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 20, 2024
gopherbot pushed a commit that referenced this issue Mar 26, 2024
@pmur @thanm
[release-branch.go1.22] cmd/internal/obj/ppc64: don't modify runtime.…
9508eae 
…elf_* symbols

The runtime.elf_* symbols are assembly functions which are used
to support the gcc/llvm -Os option when used with cgo.

When compiling Go for shared code, we attempt to strip out the
TOC regenation code added by the go assembler for these symbols.

This causes the symbol to no longer appear as an assembly
function which causes problems later on when handling other
implicit symbols.

Avoid adding a TOC regeneration prologue to these functions
to avoid this issue.

Fixes #66412

Change-Id: Icbf8e4438d177082a57bb228e39b232e7a0d7ada
Reviewed-on: https://go-review.googlesource.com/c/go/+/571835
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Paul Murphy <murp@ibm.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Lynn Boger <laboger@linux.vnet.ibm.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/572875
@gopherbot
Copy link
Author

Closed by merging 9508eae to release-branch.go1.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.22.2
Development

No branches or pull requests
2 participants
@dr2chase @gopherbot