x/mobile/cmd/gomobile: unsealed contents present in the root directory of an embedded framework #66406

ianmcfall · 2024-03-19T17:28:04Z

Go version

go version go1.21.5 darwin/arm64

Output of `go env` in your module/workspace:

GO111MODULE='on'
GOARCH='arm64'
GOBIN=''
GOCACHE='/Users/ian/Library/Caches/go-build'
GOENV='/Users/ian/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/ian/go/pkg/mod'
GONOPROXY='github.com/onlicorp/*'
GONOSUMDB='github.com/onlicorp/*'
GOOS='darwin'
GOPATH='/Users/ian/go'
GOPRIVATE='github.com/onlicorp/*'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/Users/ian/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.21.5.darwin-arm64'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/Users/ian/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.21.5.darwin-arm64/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.21.5'
GCCGO='gccgo'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/Users/ian/Developer/onli-3/vault-mobile/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/d3/dzvp6x6s76v407myqn_wmlmh0000gn/T/go-build521929990=/tmp/go-build -gno-record-gcc-switches -fno-common'

What did you do?

gomobile init
go get golang.org/x/mobile
Create XCFramework
gomobile bind -target=macos .
Attempt codesign .framework
codesign --force --sign "Developer ID Application: Comp (TeamID)" --timestamp --options runtime /path/Vault_mobile.xcframework/macos-arm64_x86_64/Vault_mobile.framework

What did you see happen?

Result of code signing framework: unsealed contents present in the root directory of an embedded framework
Context: shipping macos app for direct distribution fails to pass any binary/framework that isn't codesigned. The notarytool cli from xcode produces the following (regardless of if the xcframework is signed or not:

### Package Issues
###
Status: Invalid
Archive contains critical validation errors
[[ Safe ]]
• MyApp.app/Contents/MacOS/MyApp
• [ERROR] The signature of the binary is invalid.
• [ERROR] The signature of the binary is invalid.

What did you expect to see?

Expected contents to be sealed in the root directory of an embedded framework.

I realize this might be just an XCode issue, but considering the posts I've read about info.plists and bundling problems with the lastest XCode I figured I'd give it a shot. Any insights appreciated.

The text was updated successfully, but these errors were encountered:

dr2chase · 2024-03-20T11:47:20Z

@hyangah, any clues?

hyangah · 2024-03-20T18:50:59Z

Sorry I have no clue. Does codesign ... --verbose give more hints any chance?
It's possible that the framework bundle doesn't meet recent codesign's expected layout.

ianmcfall · 2024-03-20T20:41:54Z

@hyangah

Sorry I have no clue. Does codesign ... --verbose give more hints any chance? It's possible that the framework bundle doesn't meet recent codesign's expected layout.

Not much that tells me anything. But maybe you it'll inform you. I'm using -vvv for verbosity:

codesign -vvv --deep --strict /MyApp.app
--prepared:/MyApp.app/Contents/Frameworks/Vault_mobile.framework/Versions/Current/.
/MyApp.app/codesign-vault-only 2024-03-19 14-21-12/codesign-vault-only.app: unsealed contents present in the root directory of an embedded framework
In subcomponent: /MyApp.app/Contents/Frameworks/Vault_mobile.framework

ianmcfall · 2024-03-21T13:37:14Z

XCFramework file tree, for ref (I've included ios, iossimulator as targets as well):

Vault_mobile.xcframework
├── Info.plist
├── ios-arm64
│   └── Vault_mobile.framework
│       ├── Headers -> Versions/Current/Headers
│       ├── Info.plist
│       ├── Modules -> Versions/Current/Modules
│       ├── Resources -> Versions/Current/Resources
│       ├── Vault_mobile -> Versions/Current/Vault_mobile
│       └── Versions
│           ├── A
│           │   ├── Headers
│           │   │   ├── Universe.objc.h
│           │   │   ├── Vault_mobile.h
│           │   │   ├── Vault_mobile.objc.h
│           │   │   └── ref.h
│           │   ├── Modules
│           │   │   └── module.modulemap
│           │   ├── Resources
│           │   │   └── Info.plist
│           │   └── Vault_mobile
│           └── Current -> A
├── ios-arm64_x86_64-simulator
│   └── Vault_mobile.framework
│       ├── Headers -> Versions/Current/Headers
│       ├── Info.plist
│       ├── Modules -> Versions/Current/Modules
│       ├── Resources -> Versions/Current/Resources
│       ├── Vault_mobile -> Versions/Current/Vault_mobile
│       └── Versions
│           ├── A
│           │   ├── Headers
│           │   │   ├── Universe.objc.h
│           │   │   ├── Vault_mobile.h
│           │   │   ├── Vault_mobile.objc.h
│           │   │   └── ref.h
│           │   ├── Modules
│           │   │   └── module.modulemap
│           │   ├── Resources
│           │   │   └── Info.plist
│           │   └── Vault_mobile
│           └── Current -> A
└── macos-arm64_x86_64
    └── Vault_mobile.framework
        ├── Headers -> Versions/Current/Headers
        ├── Info.plist
        ├── Modules -> Versions/Current/Modules
        ├── Resources -> Versions/Current/Resources
        ├── Vault_mobile -> Versions/Current/Vault_mobile
        └── Versions
            ├── A
            │   ├── Headers
            │   │   ├── Universe.objc.h
            │   │   ├── Vault_mobile.h
            │   │   ├── Vault_mobile.objc.h
            │   │   └── ref.h
            │   ├── Modules
            │   │   └── module.modulemap
            │   ├── Resources
            │   │   └── Info.plist
            │   └── Vault_mobile
            └── Current -> A

34 directories, 28 files

Simon-Zeng · 2024-03-22T08:14:32Z

@ianmcfall @hyangah @dr2chase I guess the issue is due to Info.plist under macos-arm64_x86_64/Vault_mobile.framework/, as Apple has pointed out that The framework’s root must contain only the Versions directory and symlinks. Don’t place any other content there. Doing so causes code-signing problems.

Pleases refer: https://developer.apple.com/documentation/bundleresources/placing_content_in_a_bundle

ianmcfall · 2024-03-22T11:23:43Z

@Simon-Zeng Good call, thanks! codesign passes when:

gomobile bind -target=macos .
rm .../Vault_mobile.framework/Info.plist -> must explicitly remove Info.plist bc step 1 generates one at the framework root (bind generated file below):

<?xml version="1.0" encoding="UTF-8"?>
    <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
    <plist version="1.0">
      <dict>
      </dict>
    </plist>

Add XCFramework to SPM / Archive App that includes swift package / Distribute / Export & Sign (Xcode flow)
Codesign passes:

codesign -vvv --deep --strict MyApp.app

--prepared:MyApp.app/Contents/Frameworks/Vault_mobile.framework/Versions/Current/.
--validated:MyApp.app/Contents/Frameworks/Vault_mobile.framework/Versions/Current/.
MyApp.app: valid on disk
MyApp.app: satisfies its Designated Requirement

Questions

Is there a flag or some config I can pass to gomobile to prevent the extraneous framework root Info.plist from being generated? (Note: file is generated in all target framework root directories)
What purpose does it serve, especially when its contents are practically empty?

Simon-Zeng · 2024-03-25T01:42:37Z

@ianmcfall iOS requires an Info.plist located under framework root when running on Xcode 15.3 and above. So the best solution would be create an alias of Info.plist under framework root from Info.plist under {$framework root}/Versions/Current/Resources/, which will work for both iOS and Mac OS.

scosman · 2024-03-25T02:01:19Z

My fix for another issues seems to fix this as well: https://go-review.googlesource.com/c/mobile/+/574055

I can repo a code signing issue before, but not after. Different error message though.

@ianmcfall want to verify?

@Simon-Zeng the suggested symlink will fix this issue, but will cause other issues. Good call on cause!

gopherbot · 2024-03-25T02:10:29Z

Change https://go.dev/cl/574055 mentions this issue: cmd/gomobile: produce frameworks which follow Apple's specs per platform, fixing Xcode 15.3 compatibility issues

ianmcfall · 2024-03-25T12:39:49Z

Thanks for the help, everyone. Closing.

ianmcfall · 2024-03-25T12:51:38Z

My fix for another issues seems to fix this as well: https://go-review.googlesource.com/c/mobile/+/574055

I can repo a code signing issue before, but not after. Different error message though.

@ianmcfall want to verify?

@Simon-Zeng the suggested symlink will fix this issue, but will cause other issues. Good call on cause!

Apologies @scosman, not sure how I can help to verify that update. Might you share what steps I can take to try it out?

scosman · 2024-03-25T14:10:23Z

@ianmcfall Steps would be:

sync git@github.com:scosman/gomobile.git
cd cmd/gomobile
go build
The run the produced gomobile binary in cmd/gomobile to bind your library, and check it all works

…orm, fixing Xcode 15.3 compatibility issues This patch updates the framework generation code to follow the Apple spec for placing content: https://developer.apple.com/documentation/bundleresources/placing_content_in_a_bundle Previously, we setup the framework in MacOS format, and used symlinks to make it compatible with iOS format. This approach no longer works (it works locally in simulator, but causes signing issues when attempting to upload apps for distribution, or running on real hardware). We now setup the expected bundle format for each platform. Other benefits: - Thirds the size of the xcframework and resulting app binary when distributing the xcframework by zip (common for SPM and other formats). The symlinks resulted in duplicate files after zipping, which made it into the final app. - Set MinimumOSVersion, fixing SPM compatibility issue - Eliminates the blank Info.plist - Initial testing shows this also fixes golang/go#66406 (code signing issues) as a side effect of using the proper format Testing: - Tested all 4 platforms (iOS, simulator, macOS, Catalyst) on Xcode 15.3 Fixes golang/go#66406 Fixes golang/go#66500 Change-Id: I8538989efe67cb0d2d0496087dcbeca923c3dffe GitHub-Last-Rev: 28dca85 GitHub-Pull-Request: #98 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/574055 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Hajime Hoshi <hajimehoshi@gmail.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>

…orm, fixing Xcode 15.3 compatibility issues This patch updates the framework generation code to follow the Apple spec for placing content: https://developer.apple.com/documentation/bundleresources/placing_content_in_a_bundle Previously, we setup the framework in MacOS format, and used symlinks to make it compatible with iOS format. This approach no longer works (it works locally in simulator, but causes signing issues when attempting to upload apps for distribution, or running on real hardware). We now setup the expected bundle format for each platform. Other benefits: - Thirds the size of the xcframework and resulting app binary when distributing the xcframework by zip (common for SPM and other formats). The symlinks resulted in duplicate files after zipping, which made it into the final app. - Set MinimumOSVersion, fixing SPM compatibility issue - Eliminates the blank Info.plist - Initial testing shows this also fixes golang/go#66406 (code signing issues) as a side effect of using the proper format Testing: - Tested all 4 platforms (iOS, simulator, macOS, Catalyst) on Xcode 15.3 Fixes golang/go#66406 Fixes golang/go#66500 Change-Id: I8538989efe67cb0d2d0496087dcbeca923c3dffe GitHub-Last-Rev: 28dca85 GitHub-Pull-Request: golang#98 Reviewed-on: https://go-review.googlesource.com/c/mobile/+/574055 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Hajime Hoshi <hajimehoshi@gmail.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>

ianmcfall · 2024-04-04T19:38:16Z

...and check it all works

@scosman I just confirmed your git@github.com:scosman/gomobile.git passes the codesign checks successfully for a macOS app.

gopherbot added the mobile Android, iOS, and x/mobile label Mar 19, 2024

gopherbot added this to the Unreleased milestone Mar 19, 2024

hyangah added help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 20, 2024

Simon-Zeng mentioned this issue Mar 25, 2024

x/mobile: gomobile bind produces xcframework incompatible with new Xcode 15.3 requirements for iOS builds #66500

Closed

scosman mentioned this issue Mar 25, 2024

cmd/gomobile: produce frameworks which follow Apple's specs per platform, fixing Xcode 15.3 compatibility issues golang/mobile#98

Closed

ianmcfall closed this as completed Mar 25, 2024

dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/mobile/cmd/gomobile: unsealed contents present in the root directory of an embedded framework #66406

x/mobile/cmd/gomobile: unsealed contents present in the root directory of an embedded framework #66406

ianmcfall commented Mar 19, 2024

dr2chase commented Mar 20, 2024

hyangah commented Mar 20, 2024

ianmcfall commented Mar 20, 2024 •

edited

ianmcfall commented Mar 21, 2024 •

edited

Simon-Zeng commented Mar 22, 2024

ianmcfall commented Mar 22, 2024 •

edited

Simon-Zeng commented Mar 25, 2024 •

edited

scosman commented Mar 25, 2024 •

edited

gopherbot commented Mar 25, 2024

ianmcfall commented Mar 25, 2024

ianmcfall commented Mar 25, 2024 •

edited

scosman commented Mar 25, 2024

ianmcfall commented Apr 4, 2024

x/mobile/cmd/gomobile: unsealed contents present in the root directory of an embedded framework #66406

x/mobile/cmd/gomobile: unsealed contents present in the root directory of an embedded framework #66406

Comments

ianmcfall commented Mar 19, 2024

Go version

Output of go env in your module/workspace:

What did you do?

What did you see happen?

What did you expect to see?

dr2chase commented Mar 20, 2024

hyangah commented Mar 20, 2024

ianmcfall commented Mar 20, 2024 • edited

ianmcfall commented Mar 21, 2024 • edited

Simon-Zeng commented Mar 22, 2024

ianmcfall commented Mar 22, 2024 • edited

Simon-Zeng commented Mar 25, 2024 • edited

scosman commented Mar 25, 2024 • edited

gopherbot commented Mar 25, 2024

ianmcfall commented Mar 25, 2024

ianmcfall commented Mar 25, 2024 • edited

scosman commented Mar 25, 2024

ianmcfall commented Apr 4, 2024

Output of `go env` in your module/workspace:

ianmcfall commented Mar 20, 2024 •

edited

ianmcfall commented Mar 21, 2024 •

edited

ianmcfall commented Mar 22, 2024 •

edited

Simon-Zeng commented Mar 25, 2024 •

edited

scosman commented Mar 25, 2024 •

edited

ianmcfall commented Mar 25, 2024 •

edited