Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/watchflakes: possibly report newly-skipped tests #66391

Open
dmitshur opened this issue Mar 18, 2024 · 0 comments
Open

x/build/cmd/watchflakes: possibly report newly-skipped tests #66391

dmitshur opened this issue Mar 18, 2024 · 0 comments
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@dmitshur
Copy link
Contributor

It's common for Go tests that require certain capability or dependency to skip themselves if the environment doesn't meet that requirement. For example, see the various MustHave* helpers in internal/testenv.

Perhaps it'd be possible for watchflakes to detect instances of patterns where an existing test goes from passing to skipping, and report them in a useful way (i.e., a high enough signal to noise ratio). It might only be viable if it's possible to filter out cases where such changes are intended, e.g., a CL that directly adds a t.Skip(…) line to the test.

Filing this as a tracking issue.

@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. FeatureRequest labels Mar 18, 2024
@dmitshur dmitshur added this to the Unreleased milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

1 participant