Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: cmd/vet: warn on 3-clause loops where an iterator variable contains a lock type when GoVersion>=1.22 #66387

Open
timothy-king opened this issue Mar 18, 2024 · 1 comment
Labels
Milestone

Comments

@timothy-king
Copy link
Contributor

Proposal Details

Extend the copylock analyzer to emit a warning on the copy of the loop variable between iterations that occurs immediately before the loop's Post statement in Go >= 1.22. The requirements for the warning are when:

  • a 3-clause for loop declares a loop scoped variable containing a lock type,
  • the file's GoVersion is >= 1.22,
  • the name of the variable is not _, and
  • the Init statement of the for loop is not otherwise reported.

Example:

for _, mu := 0, (sync.Mutex{}); x < 10; x++ { // want "for loop iteration copies lock value to mu: sync.Mutex"
	_ = mu.TryLock()
}

Relevant part of the spec https://go.dev/ref/spec#For_clause :

The variable used by each subsequent iteration is declared implicitly before executing the post statement and initialized to the value of the previous iteration's variable at that moment.

@timothy-king
Copy link
Contributor Author

Proposed implementation http://go.dev/cl/569955.

Related #66156. This is 'Case 1'.

@timothy-king timothy-king changed the title cmd/vet: warn on 3-clause loops where an iterator variable contains a lock type when GoVersion>1.22 cmd/vet: warn on 3-clause loops where an iterator variable contains a lock type when GoVersion>=1.22 Mar 18, 2024
@ianlancetaylor ianlancetaylor changed the title cmd/vet: warn on 3-clause loops where an iterator variable contains a lock type when GoVersion>=1.22 proposal: cmd/vet: warn on 3-clause loops where an iterator variable contains a lock type when GoVersion>=1.22 Mar 27, 2024
@gopherbot gopherbot added this to the Proposal milestone Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Incoming
Development

No branches or pull requests

2 participants