Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: creation of missing package doesn't invalidate the "missing import" diagnostic #66384

Open
adonovan opened this issue Mar 18, 2024 · 1 comment
Open

x/tools/gopls: creation of missing package doesn't invalidate the "missing import" diagnostic #66384

adonovan opened this issue Mar 18, 2024 · 1 comment
Labels
gopls/metadata Issues related to metadata loading in gopls gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.16.0

Comments

@adonovan
Copy link
Member

joaotavora/eglot#550 describes an eglot bug related to a lack of invalidation. While I don't want to let eglot entirely off the hook (I think there are two bugs), I think there's a gopls invalidation bug in there too.
@adonovan adonovan added gopls Issues related to the Go language server, gopls. gopls/metadata Issues related to metadata loading in gopls labels Mar 18, 2024
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Mar 18, 2024
@gopherbot gopherbot added this to the Unreleased milestone Mar 18, 2024
@findleyr
Copy link
Contributor

This reminds me of the logic in Snapshot.clone to invalidate packages with cycles whenever an import is deleted.
We should invalidate any package with missing imports when a new package is created (or just reinitialize).

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.16.0 Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls/metadata Issues related to metadata loading in gopls gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.16.0
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr