Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: x/net/internal/socks: make it public #66320

Open
noonien opened this issue Mar 14, 2024 · 0 comments
Open

proposal: x/net/internal/socks: make it public #66320

noonien opened this issue Mar 14, 2024 · 0 comments
Labels
Milestone

Comments

@noonien
Copy link

noonien commented Mar 14, 2024

Proposal Details

x/net/proxy.SOCKS5 returns an x/net/internal/socks.Dialer, when Dialing to create a new connection, a *socks.Conn is returned, and the BoundAddr() method can be accessed by creating an interface, however, because the socks.Addr struct is not available, its fields cannot be accessed without using reflection, or parsing strings.

I'm unsure what the benefit of making the socks package internal is, but if making it non-internal is an issue, perhaps there is another way of exposing BoundAddr().

@gopherbot gopherbot added this to the Proposal milestone Mar 14, 2024
@noonien noonien changed the title proposal: import/path: proposal title proposal: x/net/internal/socks: make it public Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Incoming
Development

No branches or pull requests

2 participants