runtime: always acquire M when acquiring locks by rank #66276

rhysh · 2024-03-12T18:28:28Z

Profiling of runtime-internal locks checks gp.m.locks to see if it's
safe to add a new record to the profile, but direct use of
acquireLockRank can change the list of the M's active lock ranks without
updating gp.m.locks to match. The runtime's internal rwmutex
implementation makes a point of calling acquirem/releasem when
manipulating the lock rank list, but the other user of acquireLockRank
(the GC's Gscan bit) relied on the GC's invariants to avoid deadlocks.

Codify the rwmutex approach by renaming acquireLockRank to
acquireLockRankAndM and having it include a call to aquirem. Do the same
for release.

Fixes #64706
Fixes #66004

gopherbot · 2024-03-12T18:35:25Z

This PR (HEAD: 2f40d7d) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/571056.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-03-18T17:13:25Z

Message from Rhys Hiltner:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T17:20:01Z

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-03-18T17:06:29Z","revision":"58e504717bcf8903f34c44f00a973989d3290872"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T17:20:02Z

Message from Rhys Hiltner:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T17:20:02Z

Message from Go LUCI:

Patch Set 1:

This CL has failed the run. Reason:

Tryjob golang/try/x_tools-gotip-linux-amd64 has failed with summary (view all results):

FAILURE

go on master (change 571056)
tools on master (commit 29d17a0)

Error:
failed to run "make.bash": exit status 2

Links:

"make.bash" (combined output)

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T17:20:03Z

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T18:11:27Z

This PR (HEAD: 36bae22) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/571056.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-03-18T18:36:44Z

Message from Rhys Hiltner:

Patch Set 3: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T18:36:45Z

Message from Go LUCI:

Patch Set 3:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-03-18T18:26:05Z","revision":"fa94ff5f0523957ce54ab549cccdfe36da574a1d"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T18:36:45Z

Message from Rhys Hiltner:

Patch Set 3: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T18:36:45Z

Message from Go LUCI:

Patch Set 3:

This CL has failed the run. Reason:

Tryjob golang/try/gotip-linux-amd64-staticlockranking has failed with summary (view all results):

FAILURE

go on master (change 571056)

Error:
shard 1: failed to run "make.bash": exit status 2

Links:

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T18:36:46Z

Message from Go LUCI:

Patch Set 3: LUCI-TryBot-Result-1

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T21:24:32Z

This PR (HEAD: 1d02685) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/571056.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-03-18T21:37:34Z

Message from Rhys Hiltner:

Patch Set 4: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T21:37:35Z

Message from Go LUCI:

Patch Set 4:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-03-18T21:27:04Z","revision":"9029c99afad745ee5d69813df2c177fe434bb1c8"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T21:56:34Z

Message from Rhys Hiltner:

Patch Set 4: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T21:56:34Z

Message from Go LUCI:

Patch Set 4:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T21:56:35Z

Message from Go LUCI:

Patch Set 4: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-03-18T22:40:29Z

Message from Michael Knyszek:

Patch Set 4:

(4 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

Profiling of runtime-internal locks checks gp.m.locks to see if it's safe to add a new record to the profile, but direct use of acquireLockRank can change the list of the M's active lock ranks without updating gp.m.locks to match. The runtime's internal rwmutex implementation makes a point of calling acquirem/releasem when manipulating the lock rank list, but the other user of acquireLockRank (the GC's Gscan bit) relied on the GC's invariants to avoid deadlocks. Codify the rwmutex approach by renaming acquireLockRank to acquireLockRankAndM and having it include a call to aquirem. Do the same for release. For golang#64706 For golang#66004 Change-Id: Id18e4d8de1036de743d2937fad002c6feebe2faf

gopherbot · 2024-04-16T20:30:06Z

This PR (HEAD: 160577b) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/571056.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-04-16T20:43:08Z

Message from Rhys Hiltner:

Patch Set 5: Commit-Queue+1

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-16T20:43:09Z

Message from Go LUCI:

Patch Set 5:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2024-04-16T20:31:54Z","revision":"783081d4941107edd2fd5ce56e109c273a654075"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-16T20:43:09Z

Message from Gopher Robot:

Patch Set 5:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
A maintainer will review your change and provide feedback. See
https://go.dev/doc/contribute#review for more info and tips to get your
patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11 or adds a tag like "wait-release", it means that this CL will be
reviewed as part of the next development cycle. See https://go.dev/s/release
for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-16T21:01:01Z

Message from Rhys Hiltner:

Patch Set 5: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-16T21:01:02Z

Message from Go LUCI:

Patch Set 5:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-16T21:01:02Z

Message from Go LUCI:

Patch Set 5: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-19T17:33:00Z

Message from Michael Knyszek:

Patch Set 5:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-19T21:38:29Z

Message from Rhys Hiltner:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-19T21:51:08Z

Message from Michael Knyszek:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-19T21:57:22Z

Message from Michael Knyszek:

Patch Set 5: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-19T21:57:23Z

Message from Michael Knyszek:

Patch Set 5: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-19T21:57:23Z

Message from Rhys Hiltner:

Patch Set 5: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

gopherbot · 2024-04-19T22:37:30Z

Message from Rhys Hiltner:

Patch Set 6: Auto-Submit+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/571056.
After addressing review feedback, remember to publish your drafts!

Profiling of runtime-internal locks checks gp.m.locks to see if it's safe to add a new record to the profile, but direct use of acquireLockRank can change the list of the M's active lock ranks without updating gp.m.locks to match. The runtime's internal rwmutex implementation makes a point of calling acquirem/releasem when manipulating the lock rank list, but the other user of acquireLockRank (the GC's Gscan bit) relied on the GC's invariants to avoid deadlocks. Codify the rwmutex approach by renaming acquireLockRank to acquireLockRankAndM and having it include a call to aquirem. Do the same for release. Fixes #64706 Fixes #66004 Change-Id: Ib76eaa0cc1c45b64861d03345e17e1e843c19713 GitHub-Last-Rev: 160577b GitHub-Pull-Request: #66276 Reviewed-on: https://go-review.googlesource.com/c/go/+/571056 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Knyszek <mknyszek@google.com> Auto-Submit: Rhys Hiltner <rhys.hiltner@gmail.com> Reviewed-by: Michael Pratt <mpratt@google.com>

gopherbot · 2024-04-22T14:38:58Z

This PR is being closed because golang.org/cl/571056 has been merged.

rhysh force-pushed the issue_64706_a branch from 2f40d7d to 36bae22 Compare March 18, 2024 18:08

rhysh force-pushed the issue_64706_a branch from 36bae22 to 1d02685 Compare March 18, 2024 21:19

rhysh force-pushed the issue_64706_a branch from 1d02685 to 160577b Compare April 16, 2024 20:26

gopherbot closed this Apr 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

runtime: always acquire M when acquiring locks by rank #66276

runtime: always acquire M when acquiring locks by rank #66276

rhysh commented Mar 12, 2024 •

edited

gopherbot commented Mar 12, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Apr 16, 2024

gopherbot commented Apr 16, 2024

gopherbot commented Apr 16, 2024

gopherbot commented Apr 16, 2024

gopherbot commented Apr 16, 2024

gopherbot commented Apr 16, 2024

gopherbot commented Apr 16, 2024

gopherbot commented Apr 19, 2024

gopherbot commented Apr 19, 2024

gopherbot commented Apr 19, 2024

gopherbot commented Apr 19, 2024

gopherbot commented Apr 19, 2024

gopherbot commented Apr 19, 2024

gopherbot commented Apr 19, 2024

gopherbot commented Apr 22, 2024

runtime: always acquire M when acquiring locks by rank #66276

runtime: always acquire M when acquiring locks by rank #66276

Conversation

rhysh commented Mar 12, 2024 • edited

gopherbot commented Mar 12, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Mar 18, 2024

gopherbot commented Apr 16, 2024

gopherbot commented Apr 16, 2024

gopherbot commented Apr 16, 2024

gopherbot commented Apr 16, 2024

gopherbot commented Apr 16, 2024

gopherbot commented Apr 16, 2024

gopherbot commented Apr 16, 2024

gopherbot commented Apr 19, 2024

gopherbot commented Apr 19, 2024

gopherbot commented Apr 19, 2024

gopherbot commented Apr 19, 2024

gopherbot commented Apr 19, 2024

gopherbot commented Apr 19, 2024

gopherbot commented Apr 19, 2024

gopherbot commented Apr 22, 2024

rhysh commented Mar 12, 2024 •

edited