Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/types: gotypesalias missing calls to IncNonDefault #66216

Closed
rsc opened this issue Mar 9, 2024 · 7 comments
Closed

go/types: gotypesalias missing calls to IncNonDefault #66216

rsc opened this issue Mar 9, 2024 · 7 comments
Assignees
@griesemer
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.23

Comments

@rsc
Copy link
Contributor

rsc commented Mar 9, 2024

There is a new gotypesalias godebug but the corresponding monitoring is missing. gotypesalias.IncNonDefault needs to be called when program behavior changes from the default due to an override godebug setting. And not just whenever it is set, but whenever the setting actually changes the output, so only if an alias is observed. See 'go doc internal/godebug' for more details.
@rsc rsc added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Mar 9, 2024
@rsc rsc added this to the Go1.23 milestone Mar 9, 2024
@gopherbot
Copy link

Change https://go.dev/cl/570275 mentions this issue: internal/godebugs: test for use of IncNonDefault

gopherbot pushed a commit that referenced this issue Mar 9, 2024
@rsc
internal/godebugs: test for use of IncNonDefault
74726de 
A few recent godebugs are missing IncNonDefault uses.
Test for that, so that people remember to do it.
Filed bugs for the missing ones.

For #66215.
For #66216.
For #66217.

Change-Id: Ia3fd10fd108e1b003bb30a8bc2f83995c768fab6
Reviewed-on: https://go-review.googlesource.com/c/go/+/570275
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Damien Neil <dneil@google.com>
@cherrymui cherrymui added the compiler/runtime Issues related to the Go compiler and/or runtime. label Mar 13, 2024
@mknyszek
Copy link
Contributor

In triage we think this needs the attention of @griesemer and/or @findleyr? Please comment if I should redirect to someone else. Thanks.

@griesemer griesemer self-assigned this Mar 13, 2024
@gopherbot
Copy link

Change https://go.dev/cl/572575 mentions this issue: go/types, types2: change gotypesalias default from "0" to "1"

@dmitshur dmitshur added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Mar 27, 2024
@gopherbot
Copy link

Change https://go.dev/cl/574737 mentions this issue: go/types: changes to support materialized aliases

@cagedmantis
Copy link
Contributor

This issue was reviewed in the release meeting. Is there any status update to report on this issue?

@griesemer
Copy link
Contributor

The CL above was reverted. Reopening.

@griesemer griesemer reopened this Apr 17, 2024
@gopherbot
Copy link

Change https://go.dev/cl/579936 mentions this issue: go/types: track gotypesalias non-default behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@griesemer griesemer

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
Go Compiler / Runtime
Status: Done
Milestone
Go1.23
Development

No branches or pull requests
7 participants
@rsc @cagedmantis @mknyszek @dmitshur @griesemer @gopherbot @cherrymui